Fixed PFAnalytics for watchOS. #323
Conversation
| NSDictionary *userInfo = launchOptions[UIApplicationLaunchOptionsRemoteNotificationKey]; | ||
| #else | ||
| #elif TARGET_OS_MAC |
There was a problem hiding this comment.
Seeing as how this is set to true for all iOS derivative platforms (e.g. tvOS as well). I wonder if we can come up with a better macro here...
There was a problem hiding this comment.
I can define PF_TARGET_OS_OSX and combine !TARGET_OS_WATCH, !TARGET_OS_IOS and eventually !TARGET_OS_TV.
What do you think?
There was a problem hiding this comment.
We can do it that way, sure. I mean, we're still screwed when apple releases a new platform, but I think it's a bit less misleading that way.
There was a problem hiding this comment.
Great, did you have something specific in mind?
There was a problem hiding this comment.
I wish I did, but I can't think of anything off of the top of my head. Just stick with PF_TARGET_OS_OSX, and we can update that macro if we have any brilliant ideas on how to make it better later.
nlutsenko
force-pushed
the
nlutsenko.watchOS.analytics
branch
2 times, most recently
from
010f48f
to
68884a4
Compare
nlutsenko
force-pushed
the
nlutsenko.watchOS.analytics
branch
from
68884a4
to
2123cdc
Compare
Fixed PFAnalytics for watchOS.
Contributes to #179