Skip to content

Commit

Permalink
Merge branch 'master' into fix-live-activity-payload
Browse files Browse the repository at this point in the history
  • Loading branch information
mtrezza authored Jul 20, 2023
2 parents 2efe4b3 + 010ed4d commit c240d75
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 6 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## [5.2.2](https://github.com/parse-community/node-apn/compare/5.2.1...5.2.2) (2023-07-20)


### Bug Fixes

* Shutdown callback is not passed from provider to client ([#118](https://github.com/parse-community/node-apn/issues/118)) ([9fa197f](https://github.com/parse-community/node-apn/commit/9fa197fd92da5a56f5bdaf7d8df8dab6e85af0d1))

## [5.2.1](https://github.com/parse-community/node-apn/compare/5.2.0...5.2.1) (2023-07-16)


Expand Down
4 changes: 2 additions & 2 deletions lib/provider.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ module.exports = function (dependencies) {
);
};

Provider.prototype.shutdown = function shutdown() {
this.client.shutdown();
Provider.prototype.shutdown = function shutdown(callback) {
this.client.shutdown(callback);
};

return Provider;
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@parse/node-apn",
"description": "An interface to the Apple Push Notification service for Node.js",
"version": "5.2.1",
"version": "5.2.2",
"author": "Parse Platform, Andrew Naylor <[email protected]>",
"keywords": [
"apple",
Expand Down
5 changes: 3 additions & 2 deletions test/provider.js
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,11 @@ describe('Provider', function () {

describe('shutdown', function () {
it('invokes shutdown on the client', function () {
const callback = sinon.spy();
const provider = new Provider({});
provider.shutdown();
provider.shutdown(callback);

expect(fakes.client.shutdown).to.be.calledOnce;
expect(fakes.client.shutdown).to.be.calledOnceWithExactly(callback);
});
});
});
Expand Down

0 comments on commit c240d75

Please sign in to comment.