Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Shutdown callback is not passed from provider to client #118

Merged
merged 3 commits into from
Jul 20, 2023
Merged

fix: Shutdown callback is not passed from provider to client #118

merged 3 commits into from
Jul 20, 2023

Conversation

pigulla
Copy link

@pigulla pigulla commented Dec 8, 2022

Pass the optional shutdown callback from the Provider through to the Client.

fix #117

@pigulla
fix: pass shutdown callback through to provider
24d7597 
Pass the optional shutdown callback from the Provider through to the Client.

fix #117
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: pass shutdown callback through to provider fix: Pass shutdown callback through to provider Dec 8, 2022
@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 8, 2022 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@mtrezza
Copy link
Member

mtrezza commented Jul 16, 2023

@dplewis Would you want to review this?

@codecov
Copy link

codecov bot commented Jul 16, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5bc179d) 93.53% compared to head (dbe0821) 93.53%.

❗ Current head dbe0821 differs from pull request most recent head c04174b. Consider uploading reports for the commit c04174b to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          23       23           
  Lines         588      588           
=======================================
  Hits          550      550           
  Misses         38       38
Impacted Files Coverage Δ
lib/provider.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis
Copy link
Member

dplewis commented Jul 20, 2023

@mtrezza This looks good. Client does have a shutdown function that accepts a callback

https://github.com/parse-community/node-apn/blob/master/lib/client.js#L305-L306

@mtrezza mtrezza changed the title fix: Pass shutdown callback through to provider fix: Shutdown callback is not passed through from provider to client Jul 20, 2023
@mtrezza mtrezza changed the title fix: Shutdown callback is not passed through from provider to client fix: Shutdown callback is not passed from provider to client Jul 20, 2023
@mtrezza mtrezza merged commit 9fa197f into parse-community:master Jul 20, 2023
parseplatformorg pushed a commit that referenced this pull request Jul 20, 2023
@semantic-release-bot
chore(release): 5.2.2 [skip ci]
010ed4d 
## [5.2.2](5.2.1...5.2.2) (2023-07-20)

### Bug Fixes

* Shutdown callback is not passed from provider to client ([#118](#118)) ([9fa197f](9fa197f))
@parseplatformorg
Copy link

🎉 This change has been released in version 5.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
state:released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shutdown callback is not passed through from the Provider to the Client
4 participants
@pigulla @mtrezza @dplewis @parseplatformorg