Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Node 18, 20 #131

Closed
wants to merge 1 commit into from

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jul 16, 2023

Closes #132

Node 18, 20 tests are failing, needs further investigation.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jul 16, 2023

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 🎉

Comparison is base (650993d) 93.42% compared to head (17c45f2) 93.53%.

❗ Current head 17c45f2 differs from pull request most recent head 71032ee. Consider uploading reports for the commit 71032ee to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   93.42%   93.53%   +0.11%     
==========================================
  Files          23       23              
  Lines         578      588      +10     
==========================================
+ Hits          540      550      +10     
  Misses         38       38              
Impacted Files Coverage Δ
lib/notification/index.js 100.00% <ø> (ø)
lib/notification/apsProperties.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis
Copy link
Member

dplewis commented Sep 27, 2023

@mtrezza You can do something like this to fix the tests. Looks like there was a fix in the http2 module to correctly handle errors. Before we had to parse the error in the end event now its handled on error emitter

dplewis@5acbe59

@dplewis
Copy link
Member

dplewis commented Oct 6, 2023

@mtrezza Did you see my feedback?

@mtrezza
Copy link
Member Author

mtrezza commented Oct 6, 2023

I leave it for someone to pick this up

@mtrezza
Copy link
Member Author

mtrezza commented Oct 6, 2023

Superseded by #137.

@mtrezza mtrezza closed this Oct 6, 2023
@mtrezza mtrezza deleted the ci/add-node-versions branch November 18, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Node 18, 20
2 participants