Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minimum required Node version in engines.node has not been upgraded to Node 14 #138

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: Minimum required Node version in engines.node has not been upgraded to Node 14 #138

merged 1 commit into from
Oct 20, 2023

Conversation

wojtekmaj
Copy link

@wojtekmaj wojtekmaj commented Oct 20, 2023 •
edited
Loading

Follow up after #137

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: update engines.node to match actual requirements fix: Update engines.node to match actual requirements Oct 20, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 20, 2023 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@mtrezza mtrezza changed the title fix: Update engines.node to match actual requirements fix: Node version in engines.node is lower than Node 14 Oct 20, 2023
@mtrezza mtrezza changed the title fix: Node version in engines.node is lower than Node 14 fix: Minimum required Node version in engines.node has not been upgraded to Node 14 Oct 20, 2023
mtrezza
mtrezza approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Waiting for CI to pass...

@mtrezza mtrezza mentioned this pull request Oct 20, 2023
Merged
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f203bc1) 93.53% compared to head (a03758d) 93.53%.
Report is 1 commits behind head on master.

❗ Current head a03758d differs from pull request most recent head 5e298c6. Consider uploading reports for the commit 5e298c6 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          23       23           
  Lines         588      588           
=======================================
  Hits          550      550           
  Misses         38       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza merged commit 4eb3686 into parse-community:master Oct 20, 2023
6 checks passed
parseplatformorg pushed a commit that referenced this pull request Oct 20, 2023
@semantic-release-bot
chore(release): 6.0.1 [skip ci]
4cf2c03 
## [6.0.1](6.0.0...6.0.1) (2023-10-20)

### Bug Fixes

* Minimum required Node version in `engines.node` has not been upgraded to Node 14 ([#138](#138)) ([4eb3686](4eb3686))
@parseplatformorg
Copy link

🎉 This change has been released in version 6.0.1

@wojtekmaj wojtekmaj deleted the patch-1 branch October 21, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wojtekmaj @parseplatformorg @mtrezza