Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for target-content-id notification property #84

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Add support for target-content-id notification property #84

merged 2 commits into from
Nov 17, 2021

Conversation

ben-r-smith
Copy link

See target-content-id here and here.

@cbaker6 cbaker6 mentioned this pull request Nov 12, 2021
Closed
@cbaker6
Copy link

cbaker6 commented Nov 12, 2021 •
edited
Loading

@davimacedo @TysonAndre and this one?

@davimacedo
Copy link
Member

@benagin would you mind to fix the conflicts?

@ben-r-smith
Copy link
Author

Sure, fixed. Thanks for taking a look at this.

davimacedo
davimacedo approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@codecov
Copy link

codecov bot commented Nov 17, 2021 •
edited
Loading

Codecov Report

Merging #84 (eb497ef) into master (b27fa32) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   64.62%   64.62%           
=======================================
  Files          21       21           
  Lines         489      489           
=======================================
  Hits          316      316           
  Misses        173      173

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27fa32...eb497ef. Read the comment docs.

@davimacedo davimacedo merged commit 41d50d3 into parse-community:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbaker6 cbaker6 cbaker6 approved these changes

@davimacedo davimacedo davimacedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ben-r-smith @cbaker6 @davimacedo