-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added cancel button for new row #1690
Merged
davimacedo
merged 5 commits into
parse-community:master
from
sadakchap:cancel-btn-new-row
May 13, 2021
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
36f4ba6
added cancel button for new row
sadakchap 9b652ba
removed extra line on add new row
sadakchap 69e507a
added "add" button for new row
sadakchap 99d5801
changed order of button for new row
sadakchap 80bfbc4
Merge 'master' of parse-community/parse-dashboard into cancel-btn-new…
sadakchap File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sadakchap I've just run into this line while working on #2003 . I noticed that
attr
andprev
are not defined so it's giving me an error.I'm hesitant to change this line to
obj.revert()
but I'd like to check first with you before proceeding.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @RaschidJFR, I think we can safely remove this line.
Earlier we use to save new row(making an api call) every time a user was updating any cell(Using this). In case of error, this line would revert current selected cell value. But, now I think we don't need it as this line, as this function gets call when user hits save btn not everytime user is making change in any cell.