Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unnecessary async/await expressions #1873

Merged
merged 4 commits into from
Oct 20, 2021
Merged

refactor: remove unnecessary async/await expressions #1873

merged 4 commits into from
Oct 20, 2021

Conversation

damianstasik
Copy link
Contributor

@damianstasik damianstasik commented Oct 20, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

I noticed that the getPointerDefaultKey method in src/lib/ColumnPreferences.js awaits the value from local storage, but that is unnecessary as the returned value is not a Promise. I looked through the code to see if I can find similar cases and I did, and this PR contains a tiny refactor that gets rid of those unnecessary async/await expressions.

Related issue: #1873

Approach

Look for all async and await keywords and determine whether they are required or not.

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 20, 2021 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@damianstasik
Copy link
Contributor Author

Ready for review

mtrezza
mtrezza approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 52c315a into parse-community:alpha Oct 20, 2021
@parseplatformorg
Copy link
Contributor

🎉 This pull request has been released in version 3.3.0-alpha.9

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 20, 2021
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2021
Merged
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damianstasik @parseplatformorg @mtrezza @visualfanatic