Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upgrade semantic-release dependency #2301

Merged
merged 4 commits into from
Oct 1, 2022
Merged

refactor: upgrade semantic-release dependency #2301

merged 4 commits into from
Oct 1, 2022

Conversation

damianstasik
Copy link
Contributor

@damianstasik damianstasik commented Oct 1, 2022 •
edited
Loading

New Pull Request Checklist

Issue Description

Upgrading minimum Node.js version now allows us to upgrade semantic-release deps to latest version which requires Node 14.

Another bonus, less vulnerabilities:

Before:

found 37 vulnerabilities (4 moderate, 23 high, 10 critical)

After:

found 6 vulnerabilities (2 moderate, 2 high, 2 critical)

Related issue: #1902

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 1, 2022 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@damianstasik damianstasik requested a review from a team October 1, 2022 10:24
mtrezza
mtrezza reviewed Oct 1, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you look at the changelogs before upgrading a dependency by a major version?

For example, I think semantic release requires node >=14 in our CI environment(s).

@damianstasik
Copy link
Contributor Author

Yes, that's my usual flow, and now that we don't support Node < 14 we are clear to upgrade.

@mtrezza
Copy link
Member

mtrezza commented Oct 1, 2022 •
edited
Loading

now that we don't support Node < 14 we are clear to upgrade.

These are 2 different things:

  • with which Node version is the product tested
  • which node versions do the CI jobs run with

Did you check the CI job node versions? - There may be multiple workflow files affected.

@damianstasik
Copy link
Contributor Author

These are 2 different things

I understand that, and my confirmation was in regards to both. We don't use Node.js < 14.20 in CI, I checked that before I created the PR.

@mtrezza
Copy link
Member

mtrezza commented Oct 1, 2022

Amazing, just wanted to make sure so we don't overlook anything. Thanks for confirming.

mtrezza
mtrezza approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title refactor: upgrade semantic-release deps refactor: upgrade semantic-release dependency Oct 1, 2022
@mtrezza mtrezza merged commit c3bb6a1 into parse-community:alpha Oct 1, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 9, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 17, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 1, 2022
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Dec 25, 2022
@cycqitianwushuge
Merge branch 'release'
0b9d770 
* release: (41 commits)
  chore(release): 5.0.0 [skip ci]
  ci: release commit
  chore(release): 5.0.0-beta.1 [skip ci]
  chore(release): 5.0.0-alpha.7 [skip ci]
  fix: using browser navigation backward / forward button clears data browser (parse-community#2317)
  docs: update changelog
  chore(release): 5.0.0-alpha.6 [skip ci]
  fix: raw value of read-only date field in data browser cannot be copied (parse-community#2326)
  chore(release): 5.0.0-alpha.5 [skip ci]
  feat: improve distinction between deletion confirmation dialogs (parse-community#2319)
  refactor: upgrade otpauth from 8.0.2 to 8.0.3 (parse-community#2322)
  refactor: upgrade graphiql from 2.0.7 to 2.0.8 (parse-community#2321)
  chore(release): 5.0.0-alpha.4 [skip ci]
  feat: keep entered filter value when changing filter operator (parse-community#2313)
  refactor: upgrade typescript from 4.8.2 to 4.8.3 (parse-community#2308)
  refactor: bump json-schema and jsprim (parse-community#2303)
  refactor: upgrade linting dependencies (parse-community#1946)
  refactor: upgrade semantic-release dependency (parse-community#2301)
  refactor: upgrade React Router to v6 (parse-community#1954)
  refactor: upgrade styling dependencies (parse-community#2300)
  ...

# Conflicts:
#	package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damianstasik @mtrezza @parseplatformorg