Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove warnings in Docker build #2350

Merged
merged 4 commits into from
Jan 28, 2023
Merged

refactor: Remove warnings in Docker build #2350

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac60896
feat: improve Dockerfile to conform to best practices
cbaker6 Dec 23, 2022
dfd5aa9
fix production warning in docker build
cbaker6 Dec 23, 2022
cfe7fe8
Merge branch 'alpha' into slimImage
cbaker6 Jan 9, 2023
67350e3
Merge branch 'alpha' into slimImage
mtrezza Jan 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
############################################################
# Build stage
############################################################
FROM node:lts-alpine AS base
FROM node:lts-alpine AS build

RUN apk update; \
apk add git;
RUN apk --no-cache add git
WORKDIR /src

# Copy package.json first to benefit from layer caching
COPY package*.json ./

# Install without scripts otherwise webpack will fail
RUN npm ci --production --ignore-scripts
RUN npm ci --omit=dev --ignore-scripts

# Copy production node_modules aside for later
RUN cp -R node_modules prod_node_modules
Expand All @@ -32,11 +31,11 @@ FROM node:lts-alpine AS release
WORKDIR /src

# Copy production node_modules
COPY --from=base /src/prod_node_modules /src/node_modules
COPY --from=base /src/package*.json /src/
COPY --from=build /src/prod_node_modules /src/node_modules
COPY --from=build /src/package*.json /src/

# Copy compiled src dirs
COPY --from=base /src/Parse-Dashboard/ /src/Parse-Dashboard/
COPY --from=build /src/Parse-Dashboard/ /src/Parse-Dashboard/

USER node

Expand Down