Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from fileKey to encryptionKey #17

Merged
merged 7 commits into from
Oct 26, 2020
Merged

Switch from fileKey to encryptionKey #17

merged 7 commits into from
Oct 26, 2020

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Oct 24, 2020

No description provided.

@ghost
Copy link

ghost commented Oct 24, 2020

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #17 into master will increase coverage by 1.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   89.31%   90.83%   +1.52%     
==========================================
  Files           1        1              
  Lines         131      131              
==========================================
+ Hits          117      119       +2     
+ Misses         14       12       -2     
Impacted Files Coverage Δ
index.js 90.83% <100.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6bc40...a65d5b5. Read the comment docs.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Oct 24, 2020

@davimacedo let me know if you want me to bump the version number to 1.2

@davimacedo
Copy link
Member

Yes. Let's do that.

@davimacedo
Copy link
Member

LGTM!

@davimacedo davimacedo merged commit 0ce3174 into master Oct 26, 2020
@cbaker6 cbaker6 deleted the encryptionKey branch October 27, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants