Skip to content

Commit

Permalink
fix: combined and query with relational query condition returns inc…
Browse files Browse the repository at this point in the history
…orrect results (#7593)
  • Loading branch information
Kingtous authored Oct 29, 2021
1 parent edb03f2 commit 174886e
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 1 deletion.
19 changes: 19 additions & 0 deletions spec/CloudCode.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3524,4 +3524,23 @@ describe('sendEmail', () => {
'Failed to send email because no mail adapter is configured for Parse Server.'
);
});

it('should have object found with nested relational data query', async () => {
const obj1 = Parse.Object.extend('TestObject');
const obj2 = Parse.Object.extend('TestObject2');
let item2 = new obj2();
item2 = await item2.save();
let item1 = new obj1();
const relation = item1.relation('rel');
relation.add(item2);
item1 = await item1.save();
Parse.Cloud.beforeFind('TestObject', req => {
const additionalQ = new Parse.Query('TestObject');
additionalQ.equalTo('rel', item2);
return Parse.Query.and(req.query, additionalQ);
});
const q = new Parse.Query('TestObject');
const res = await q.first();
expect(res.id).toEqual(item1.id);
});
});
20 changes: 19 additions & 1 deletion src/Controllers/DatabaseController.js
Original file line number Diff line number Diff line change
Expand Up @@ -971,6 +971,18 @@ class DatabaseController {
return Promise.resolve(query);
});
}
if (query['$and']) {
const ors = query['$and'];
return Promise.all(
ors.map((aQuery, index) => {
return this.reduceInRelation(className, aQuery, schema).then(aQuery => {
query['$and'][index] = aQuery;
});
})
).then(() => {
return Promise.resolve(query);
});
}

const promises = Object.keys(query).map(key => {
const t = schema.getExpectedType(className, key);
Expand Down Expand Up @@ -1049,7 +1061,13 @@ class DatabaseController {
})
);
}

if (query['$and']) {
return Promise.all(
query['$and'].map(aQuery => {
return this.reduceRelationKeys(className, aQuery, queryOptions);
})
);
}
var relatedTo = query['$relatedTo'];
if (relatedTo) {
return this.relatedIds(
Expand Down

0 comments on commit 174886e

Please sign in to comment.