Refactor files.js into FilesController. #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlutsenko
force-pushed
the
nlutsenko.es6.adapters
branch
from
03ba962
to
69593b8
Compare
|
While you're at it, any opposition to moving all the handlers or controllers into a sub directory, starting with this one? |
nlutsenko
force-pushed
the
nlutsenko.es6.adapters
branch
from
69593b8
to
cee2d26
Compare
|
Yup, no opposition, good idea, moving to |
nlutsenko
force-pushed
the
nlutsenko.es6.adapters
branch
from
cee2d26
to
c2e7b53
Compare
| @@ -0,0 +1,95 @@ | |||
| // files.js | |||
|
@nlutsenko updated the pull request. |
nlutsenko
force-pushed
the
nlutsenko.es6.adapters
branch
from
c2e7b53
to
53b2d4e
Compare
|
Updated with ES6 import style and updated the comment. |
|
@nlutsenko updated the pull request. |
nlutsenko
added a commit
that referenced
this pull request
Feb 9, 2016
Refactor files.js into FilesController.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nicer structure, get rid of globals, follow-up PR from #315.