Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AuthAdapters): Do not revalidate auth data if hasn't changed #3872

Merged
merged 2 commits into from
May 28, 2017

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented May 28, 2017

  • Adds test for user PUT requests (updates) when possibly stale authData is passed (as iOS does)
  • Provides a fix to skip validation when the AuthData hasn't changed on PUT either.

Fixes #3867

@flovilmart flovilmart requested a review from acinader May 28, 2017 14:31
@codecov
Copy link

codecov bot commented May 28, 2017

Codecov Report

Merging #3872 into master will decrease coverage by 1.71%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3872      +/-   ##
==========================================
- Coverage   90.17%   88.45%   -1.72%     
==========================================
  Files         114      114              
  Lines        7550     7703     +153     
==========================================
+ Hits         6808     6814       +6     
- Misses        742      889     +147
Impacted Files Coverage Δ
src/RestWrite.js 93.11% <100%> (-0.16%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 79.01% <0%> (-16.45%) ⬇️
src/Controllers/DatabaseController.js 94.54% <0%> (+0.2%) ⬆️
src/Routers/UsersRouter.js 90.37% <0%> (+1.48%) ⬆️
src/Adapters/Cache/InMemoryCache.js 100% <0%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aedaae1...6b3a15d. Read the comment docs.

@flovilmart flovilmart merged commit 57efd89 into master May 28, 2017
@flovilmart flovilmart deleted the fix/3867 branch May 28, 2017 21:50
@EricNetsch EricNetsch mentioned this pull request May 24, 2020
@Moumouls Moumouls mentioned this pull request Dec 17, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted authData validation
2 participants