Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IGNORE] Fixing CI Issue, Add Indexes to Schema API #4322

Closed
wants to merge 9 commits into from

Conversation

montymxb
Copy link
Contributor

@montymxb montymxb commented Nov 5, 2017

There is a CI issue with #4240 that does not appear to manifest locally. I've created this PR to attempt to isolate the issue in the CI specifically. I also cleaned up the commit history.

This is just to diagnose and identify the issue, once it has been identified I'll close this back out.

@codecov
Copy link

codecov bot commented Nov 5, 2017

Codecov Report

Merging #4322 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4322      +/-   ##
==========================================
+ Coverage   92.52%   92.62%   +0.09%     
==========================================
  Files         118      118              
  Lines        8256     8374     +118     
==========================================
+ Hits         7639     7756     +117     
- Misses        617      618       +1
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.77% <100%> (+0.15%) ⬆️
...rc/Adapters/Storage/Mongo/MongoSchemaCollection.js 96.25% <100%> (+0.14%) ⬆️
src/Routers/SchemasRouter.js 97.91% <100%> (ø) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 94.46% <100%> (+1.5%) ⬆️
src/Controllers/SchemaController.js 97.19% <100%> (+0.1%) ⬆️
src/Controllers/DatabaseController.js 94.49% <100%> (-0.19%) ⬇️
src/RestWrite.js 93.39% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d163269...8ee6e44. Read the comment docs.

@montymxb
Copy link
Contributor Author

montymxb commented Nov 6, 2017

Resolved issue. Found to be an uncaught error being returned when attempting to auto-update the schema with indexes on startup, particularly with default classes _User and _Role.

Nothing definitively indicates why this only showed up in the CI, but I believe it had to do with some degree of timing. Adjusting local tests so that the auto-addition of indexes was done a bit later caused this error to show up in numerous places locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants