fix(directAccess/cloud-code): Pass installationId with LogIn #6903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InstallationId didn't get passed correctly. Resulting in _Session without installationId https://github.com/parse-community/parse-server/blob/master/src/Routers/UsersRouter.js#L263 * Fixed error with POST /login and req.query is undefined
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #6903 +/- ##
==========================================
- Coverage 93.83% 93.81% -0.03%
==========================================
Files 169 169
Lines 12220 12220
==========================================
- Hits 11467 11464 -3
- Misses 753 756 +3
Continue to review full report at Codecov.
|
TylerBrock
pushed a commit
to Hustle/parse-server
that referenced
this pull request
Sep 22, 2020
…ommunity#6903) InstallationId didn't get passed correctly. Resulting in _Session without installationId https://github.com/parse-community/parse-server/blob/master/src/Routers/UsersRouter.js#L263 * Fixed error with POST /login and req.query is undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstallationId didn't get passed correctly. Resulting in _Session without installationId
https://github.com/parse-community/parse-server/blob/master/src/Routers/UsersRouter.js#L263
Let me know if more tests are needed.