Add Github process to contributing guide #7105
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7105 +/- ##
==========================================
+ Coverage 93.65% 93.97% +0.32%
==========================================
Files 169 172 +3
Lines 12508 12835 +327
==========================================
+ Hits 11714 12062 +348
+ Misses 794 773 -21
Continue to review full report at Codecov.
|
|
That's a good one! A process description for this would surely be helpful. This should incorporate any conclusions from #7051. |
|
Could we add a not about the importance of documentation changes, perhaps to the please do's? |
|
@TomWFox changed to "Please Do's" |
|
I didn't mean for you to move what you had already done to the Please Do's (I think that was great as it was!) I just thought it would be good to add a point about documentation there e.g. You could revert the last commit. |
This reverts commit 331d7dc.
* Update CONTRIBUTING.md * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Revert "Update CONTRIBUTING.md" This reverts commit 331d7dc. * Update CONTRIBUTING.md
|
🎉 This change has been released in version 5.0.0-beta.1 |
|
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
As far as I can tell, there are no references in the contributing guide to the expected GitHub process (e.g open issue -> discuss approach -> open PR)
The guide currently jumps to "submit a PR", which I know makes @mtrezza annoyed, but more importantly, can make new contributors assume that any new feature should be submitted straight through a PR, not an FR first.
Related issue: #7100