-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting patterns in classNames for Live Queries #7131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7131 +/- ##
==========================================
+ Coverage 93.89% 93.92% +0.02%
==========================================
Files 169 169
Lines 12530 12535 +5
==========================================
+ Hits 11765 11773 +8
+ Misses 765 762 -3
Continue to review full report at Codecov.
|
Looks good, thank you for getting started on this highly requested feature. Can you write a test case to ensure it works? |
Is it ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* add-account-unlock-on-password-reset: moved changelog entry to correct position Added docs entry added changelog entry added account policy option added account unlock on password reset fix: upgrade ws from 7.4.1 to 7.4.2 (parse-community#7132) Supporting patterns in classNames for Live Queries (parse-community#7131) add api mail adapter to mail adapter list (parse-community#7126) # Conflicts: # CHANGELOG.md # src/Config.js # src/Options/Definitions.js
) * Parse LiveQuery Server. Supporting patterns in classNames. * Parse LiveQuery Server. Supporting patterns in classNames. Small optimisation. * Parse LiveQuery Server. Supporting patterns in classNames. Adding info to changelog. * Parse LiveQuery Server. Supporting patterns in classNames. Test case.
* Parse LiveQuery Server. Supporting patterns in classNames. * Parse LiveQuery Server. Supporting patterns in classNames. Small optimisation. * Parse LiveQuery Server. Supporting patterns in classNames. Adding info to changelog. * Parse LiveQuery Server. Supporting patterns in classNames. Test case.
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
The PR allows to use patterns (regexps) in LiveQuery's parameter
classNames
. This makes it possible to use subscription at classes that are not known at the time of server configuring.There is full backward compatibility.
Related issue
TODOs before merging