Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Prettier after Definitions #7164

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Feb 4, 2021

New Pull Request Checklist

Issue Description

npm run definitions replaces quotation marks resulting in a lot of changes across the options files, until prettier is ran. This runs prettier on the options folder straight after the options files are built.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #7164 (b76bc99) into master (08b2ea4) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7164      +/-   ##
==========================================
- Coverage   93.93%   93.89%   -0.04%     
==========================================
  Files         169      169              
  Lines       12547    12547              
==========================================
- Hits        11786    11781       -5     
- Misses        761      766       +5     
Impacted Files Coverage Δ
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.84% <0.00%> (-0.68%) ⬇️
src/Controllers/SchemaController.js 97.13% <0.00%> (-0.20%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.85% <0.00%> (-0.08%) ⬇️
src/RestWrite.js 93.84% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b2ea4...b8e49a7. Read the comment docs.

@dplewis dplewis merged commit 38f33e5 into parse-community:master Feb 4, 2021
@dplewis dplewis deleted the patch-5 branch February 4, 2021 08:33
mtrezza added a commit to mtrezza/parse-server that referenced this pull request Feb 7, 2021
…-localization

* commit '6097e82194772847954dc2c2b7559543cc7531cc':
  fix: upgrade mime from 2.4.7 to 2.5.0 (parse-community#7166)
  fix: upgrade pg-promise from 10.8.7 to 10.9.0 (parse-community#7168)
  fix: upgrade apollo-server-express from 2.19.1 to 2.19.2 (parse-community#7165)
  Upgrade @node-rs/bcrypt to latest version (parse-community#7159)
  Run Prettier after Definitions (parse-community#7164)

# Conflicts:
#	package-lock.json
mtrezza added a commit to mtrezza/parse-server that referenced this pull request Feb 9, 2021
* commit '7f47b0427ea56214d9b0199f0fcfa4af38794e02':
  Add page localization (parse-community#7128)
  Improve contribution guide (parse-community#7075)
  fix: upgrade pg-promise from 10.9.0 to 10.9.1 (parse-community#7170)
  Add tests against multiple MongoDB versions (parse-community#7161)
  fix: upgrade mime from 2.4.7 to 2.5.0 (parse-community#7166)
  fix: upgrade pg-promise from 10.8.7 to 10.9.0 (parse-community#7168)
  fix: upgrade apollo-server-express from 2.19.1 to 2.19.2 (parse-community#7165)
  Upgrade @node-rs/bcrypt to latest version (parse-community#7159)
  Run Prettier after Definitions (parse-community#7164)
dplewis pushed a commit that referenced this pull request Feb 21, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants