-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test4 #7212
Fix flaky test4 #7212
Conversation
… to be done in time-fahsion way
Codecov Report
@@ Coverage Diff @@
## master #7212 +/- ##
==========================================
+ Coverage 94.00% 94.02% +0.02%
==========================================
Files 172 172
Lines 12868 12868
==========================================
+ Hits 12096 12099 +3
+ Misses 772 769 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can we merge this one yet? |
Do you have a script or gist I can use to do this too? |
* Increase timeout for redis tests * Remove for * Increase little bit more one of the tests since it requires two calls to be done in time-fahsion way * increase default ttl a bit more
I use to wrap the test(s) that I want to investigate with a for. Something like: for (let x = 0; x < 300; x++) {
fit(...);
} |
I figured as much, I thought it was built into jasmine. |
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
"RedisCacheAdapter should find un-expired records" and other similar tests are flaky because sometimes the cache expires before the first get since it has a very low ttl value. A similar test was fixed in the past but not all of them: https://github.com/parse-community/parse-server/pull/5686/files
Related issue: #7180
Approach
Basically I increased the default ttl for the cache adapter in the tests. I've run all tests 300 times with no failures.
TODOs before merging