Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Increase coverage #7654

Open
wants to merge 25 commits into
base: alpha
Choose a base branch
from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Oct 26, 2021

New Pull Request Checklist

Issue Description

Increases coverage by adding some more tests

Related issue: #7563

Approach

Adds a few more test cases

TODOs before merging

  • Add test cases

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 26, 2021

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Base: 94.27% // Head: 94.07% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (737c3ff) compared to base (6323368).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 737c3ff differs from pull request most recent head 4d3bf0f. Consider uploading reports for the commit 4d3bf0f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #7654      +/-   ##
==========================================
- Coverage   94.27%   94.07%   -0.21%     
==========================================
  Files         180      180              
  Lines       13987    13984       -3     
==========================================
- Hits        13186    13155      -31     
- Misses        801      829      +28     
Impacted Files Coverage Δ
src/cli/parse-server.js 70.31% <ø> (+37.50%) ⬆️
src/cli/utils/runner.js 100.00% <100.00%> (+13.63%) ⬆️
src/Adapters/Cache/RedisCacheAdapter.js 15.55% <0.00%> (-75.56%) ⬇️
src/LiveQuery/ParseCloudCodePublisher.js 83.33% <0.00%> (-16.67%) ⬇️
src/Routers/AggregateRouter.js 92.00% <0.00%> (-8.00%) ⬇️
src/ParseServerRESTController.js 92.42% <0.00%> (-6.07%) ⬇️
src/batch.js 89.47% <0.00%> (-5.27%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 90.63% <0.00%> (-2.35%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 93.43% <0.00%> (-0.73%) ⬇️
src/RestWrite.js 94.61% <0.00%> (-0.30%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza
Copy link
Member

mtrezza commented Mar 22, 2022

@dblythy Is this ready for review?

@mtrezza mtrezza changed the title refactor: increase coverage ci: increase coverage Mar 22, 2022
@mtrezza mtrezza changed the title ci: increase coverage test: increase coverage Mar 22, 2022
@dblythy
Copy link
Member Author

dblythy commented Mar 26, 2022

Just need to get tests to pass

dblythy and others added 8 commits March 26, 2022 15:29
## [5.2.1-alpha.2](parse-community/parse-server@5.2.1-alpha.1...5.2.1-alpha.2) (2022-03-26)

### Performance Improvements

* reduce database operations when using the constant parameter in Cloud Function validation ([parse-community#7892](parse-community#7892)) ([48bd512](parse-community@48bd512))
# [5.3.0-alpha.2](parse-community/parse-server@5.3.0-alpha.1...5.3.0-alpha.2) (2022-03-27)

### Bug Fixes

* security upgrade parse push adapter from 4.1.0 to 4.1.2 ([parse-community#7893](parse-community#7893)) ([ef56e98](parse-community@ef56e98))
@mtrezza mtrezza force-pushed the alpha branch 2 times, most recently from 59215e6 to e6d7d8f Compare May 1, 2022 02:29
@dblythy dblythy closed this Dec 15, 2022
@dblythy dblythy reopened this Dec 20, 2022
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title test: increase coverage test: Increase coverage Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants