Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAP: Decide on what markers to use for cases and orgs in the map #260

Closed
davidascher opened this issue Apr 23, 2017 · 8 comments
Closed
Assignees

Comments

@davidascher
Copy link
Contributor

davidascher commented Apr 23, 2017

We can use any of the icons in material icons (https://material.io/icons/) or font-awesome (http://fontawesome.io/, not sure what version). I'd prefer it if we didn't have to use new icons, at least for now (because mapbox doesn't make it trivial).

Can pick whatever color, size.

(for implementation, see MapVisualization.js and mapbox/mapbox-gl-js#3605 (comment) for the magic incantations.

Currently:

screenshot 2017-04-23 13 41 15

@davidascher davidascher changed the title Decide on what markers to use for cases and orgs in the map MAP: Decide on what markers to use for cases and orgs in the map Apr 23, 2017
@slamwiser
Copy link

@jesicarson @davidascher - If we're limited in terms of icons, then let's go for the standard "place" icon from google material. I'm not certain about colour - I think we should check with amber for approval - My assumption is that black (#333) is preferred (can we add a white outline? + drop/text shadow?) - if not, then we should stick with the interactive colour (red #ec1414). - we should also add a hover state colour - lightened by 15%.

@davidascher
Copy link
Contributor Author

don't we want to distinguish cases & orgs?

@slamwiser
Copy link

slamwiser commented Apr 25, 2017 via email

@davidascher
Copy link
Contributor Author

It should but it doesn't yet. Good point to notice.

@jesicarson
Copy link
Member

Two colours might also be fine without a legend, since the word case/org will appear on click in the white box and people will very quickly figure that out. Also it indicates that something multi-layered is going on on the map at first glance. But I agree we should check with Amber. For now I'd say try red and black as Sam suggested. Although for hover, I'm not sure I like the idea of lightening the red, is there another way to indicate hover for red pins, or do we have to? Can it just be click to activate the info box, no hover state change?

@davidascher
Copy link
Contributor Author

Decision is:

  • we'll use black (or dark grey) markers for cases and methods
  • we'll use the highlight color (or a derivative) to show pins that correspond to the search results.

@jesicarson
Copy link
Member

Black please

@davidascher
Copy link
Contributor Author

took out the remaining bits in #288, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants