fix: adjust downloads to align with new package names introduced #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Will this work for versions <= v1.46.1? |
|
@mhagnumdw it's not backwards compatible, but I could spend an extra cycle to make sure it is. |
|
You can add a condition based on the version. |
|
@mhagnumdw I made some changes, so if you could test the newer version, I'd really appreciate it. |
|
@stephan-breitrainer, I switched to pre and post v1.46.1 versions and everything is fine Linux Fedora 40 x86_64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new schema to name the packages for the gitlab-cli tool was introduced in https://gitlab.com/gitlab-org/cli/-/merge_requests/1701, and this MR makes sure to download the correct archive.
Fixes #10