-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces ConnectorMetadata/BindingPath with the catalog interfaces. #1536
Conversation
This is a draft because I am working on confirming any impact to the conformance tests which @johnedquinn has worked so hard one 😁 |
CROSS-ENGINE Conformance Report ❌
Testing DetailsResult Details
Now Failing Tests ❌The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. Now Passing Tests468 test(s) were previously failing in BASE (LEGACY-14839F7) but now pass in TARGET (EVAL-14839F7). Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. CROSS-COMMIT-LEGACY Conformance Report ✅
Testing DetailsResult Details
CROSS-COMMIT-EVAL Conformance Report ❌
Testing DetailsResult Details
Now Failing Tests ❌The following 1 test(s) were previously PASSING in BASE but are now FAILING in TARGET: Click here to see
Now Passing TestsThe following 1 test(s) were previously FAILING in BASE but are now PASSING in TARGET. Before merging, confirm they are intended to pass: Click here to see
|
Relevant Issues
#1496
Description
This PR replaces ConnectorMetadata with BindingPath/BindingName to use the Catalog interfaces such as Catalog, Identifier, Name, and Table. This is an intermediate step to replace the metadata layer with the catalog interfaces. This PR HAS to update the plugins, and it replaces PartiQLValue in the bindings to use Datum.
Finally, it introduces an initial implementation of the IonDatum which fills the role of the original Ion-valued backed ExprValue.
Other Information
and Code Style Guidelines? YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.