Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces ConnectorMetadata/BindingPath with the catalog interfaces. #1536

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

RCHowell
Copy link
Member

@RCHowell RCHowell commented Aug 5, 2024

Relevant Issues

#1496

Description

This PR replaces ConnectorMetadata with BindingPath/BindingName to use the Catalog interfaces such as Catalog, Identifier, Name, and Table. This is an intermediate step to replace the metadata layer with the catalog interfaces. This PR HAS to update the plugins, and it replaces PartiQLValue in the bindings to use Datum.

Finally, it introduces an initial implementation of the IonDatum which fills the role of the original Ion-valued backed ExprValue.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@RCHowell
Copy link
Member Author

RCHowell commented Aug 5, 2024

This is a draft because I am working on confirming any impact to the conformance tests which @johnedquinn has worked so hard one 😁

Copy link

github-actions bot commented Aug 5, 2024

CROSS-ENGINE Conformance Report ❌

BASE (LEGACY-14839F7) TARGET (EVAL-14839F7) +/-
% Passing 90.72% 96.41% 5.69% ✅
Passing 5329 5664 335 ✅
Failing 545 211 -334 ✅
Ignored 0 0 0 ✅
Total Tests 5874 5875 1 ✅

Testing Details

  • Base Commit: 14839f7
  • Base Engine: LEGACY
  • Target Commit: 14839f7
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing Tests. ❌
  • Passing in both: 5196
  • Failing in both: 77
  • PASSING in BASE but now FAILING in TARGET: 134
  • FAILING in BASE but now PASSING in TARGET: 468

Now Failing Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now Passing Tests

468 test(s) were previously failing in BASE (LEGACY-14839F7) but now pass in TARGET (EVAL-14839F7). Before merging, confirm they are intended to pass.

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-LEGACY Conformance Report ✅

BASE (LEGACY-DB9B6BD) TARGET (LEGACY-14839F7) +/-
% Passing 90.72% 90.72% 0.00% ✅
Passing 5329 5329 0 ✅
Failing 545 545 0 ✅
Ignored 0 0 0 ✅
Total Tests 5874 5874 0 ✅

Testing Details

  • Base Commit: db9b6bd
  • Base Engine: LEGACY
  • Target Commit: 14839f7
  • Target Engine: LEGACY

Result Details

  • Passing in both: 5329
  • Failing in both: 545
  • PASSING in BASE but now FAILING in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0

CROSS-COMMIT-EVAL Conformance Report ❌

BASE (EVAL-DB9B6BD) TARGET (EVAL-14839F7) +/-
% Passing 96.41% 96.41% 0.00% ✅
Passing 5664 5664 0 ✅
Failing 211 211 0 ✅
Ignored 0 0 0 ✅
Total Tests 5875 5875 0 ✅

Testing Details

  • Base Commit: db9b6bd
  • Base Engine: EVAL
  • Target Commit: 14839f7
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing Tests. ❌
  • Passing in both: 5664
  • Failing in both: 211
  • PASSING in BASE but now FAILING in TARGET: 1
  • FAILING in BASE but now PASSING in TARGET: 1

Now Failing Tests ❌

The following 1 test(s) were previously PASSING in BASE but are now FAILING in TARGET:

Click here to see
  1. Example 6 — Value Coercion, compileOption: LEGACY

Now Passing Tests

The following 1 test(s) were previously FAILING in BASE but are now PASSING in TARGET. Before merging, confirm they are intended to pass:

Click here to see
  1. Example 6 — Value Coercion, compileOption: LEGACY

@RCHowell RCHowell marked this pull request as ready for review August 14, 2024 20:03
@RCHowell RCHowell mentioned this pull request Aug 14, 2024
17 tasks
@RCHowell RCHowell merged commit 7aeb1be into v1 Aug 21, 2024
14 checks passed
@RCHowell RCHowell deleted the v1-connector branch August 21, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants