NON-OS SDK support. Tested on v2.0.0. #10
Conversation
|
Thanks! Will check on the weekend! |
| // 7 Bit Slave Address; SCL Frequency in Steps of 100 KHz, range: 100 -- 1000 KHz | ||
|
|
||
| i2c_slave_address = slave_address; | ||
| if (i2c_SCL_frequency != SCL_frequency_KHz) { | ||
| uint16_t fr_sel = round(SCL_frequency_KHz / 100.0); |
There was a problem hiding this comment.
I would like to keep that with the round(.), such that frequencies are rounded up to next 100 level. Guess that's ok for NON-OS as well.
| @@ -708,13 +726,14 @@ void ICACHE_RAM_ATTR brzo_i2c_read(uint8_t *data, uint8_t nr_of_bytes, boolean r | |||
| return; | |||
| } | |||
|
|
|||
| void ICACHE_RAM_ATTR brzo_i2c_start_transaction(uint8_t slave_address, uint16_t SCL_frequency_KHz) { | |||
| void ICACHE_FLASH_ATTR brzo_i2c_start_transaction(uint8_t slave_address, uint16_t SCL_frequency_KHz) | |||
There was a problem hiding this comment.
Although wasting a bit of IRAM, I would like to keep the brzo_i2c_start_transaction and its counterpart bzro_i2c_end_transaction in IRAM, i.e. not ICACHE_FLASH_ATTR. As I learned (the hard way), moving from ROM to RAM can take up 3--4 usec, cf. my issue here. There are many use cases, where you want to start i2c transactions right away, thus I would keep RAM attribute.
|
About round(). I prefer to not use floating point calculation in embedded development when it is possible to implement functionality without it. In your case this can be achieved next way: |
Related discussion - #9