Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-31095) feat(profile): Add analytics for DeletProfileReason #6751

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Lucasbeneston
Copy link
Contributor

@Lucasbeneston Lucasbeneston commented Aug 9, 2024

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-31095

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS
Android
Phone - Chrome
Desktop - Chrome

Copy link

github-actions bot commented Aug 9, 2024

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Search Results - Performance test for Search Results page 13.8 ms → 13.7 ms (-0.1 ms, -0.7%) 5 → 5
Performance test for Favorites page 56.3 ms → 56.0 ms (-0.3 ms, -0.5%) 6 → 6
Performance test for Venue page 2.5 ms → 2.2 ms (-0.3 ms, -12.0%) 1 → 1
Performance test for EndedBookings page 29.4 ms → 28.6 ms (-0.8 ms, -2.7%) 7 → 7
Performance test for Profile page 6.7 ms → 5.8 ms (-0.9 ms, -13.4%) 5.70 → 5 (-0.7000000000000002, -12.3%) 🟢
Performance test for Bookings page 38.5 ms → 37.4 ms (-1.1 ms, -2.9%) 7 → 7
Search Landing Page - Performance test for Search Landing page 15.1 ms → 13.6 ms (-1.5 ms, -9.9%) 5 → 5
Performance test for Offer page 208.2 ms → 203.8 ms (-4.4 ms, -2.1%) 5 → 5
Show details
Name Render Duration Render Count
Search Results - Performance test for Search Results page Baseline
Mean: 13.8 ms
Stdev: 0.9 ms (6.7%)
Runs: 15 15 14 14 14 14 14 13 13 12

Current
Mean: 13.7 ms
Stdev: 1.6 ms (11.4%)
Runs: 16 15 15 15 14 13 13 13 12 11
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Favorites page Baseline
Mean: 56.3 ms
Stdev: 3.1 ms (5.4%)
Runs: 62 61 57 56 56 55 55 55 54 52

Current
Mean: 56.0 ms
Stdev: 2.2 ms (3.9%)
Runs: 59 58 57 57 57 57 55 54 54 52
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Venue page Baseline
Mean: 2.5 ms
Stdev: 0.5 ms (21.1%)
Runs: 3 3 3 3 3 2 2 2 2 2

Current
Mean: 2.2 ms
Stdev: 0.4 ms (19.2%)
Runs: 3 3 2 2 2 2 2 2 2 2
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Performance test for EndedBookings page Baseline
Mean: 29.4 ms
Stdev: 1.7 ms (5.8%)
Runs: 32 31 31 30 30 29 29 28 27 27

Current
Mean: 28.6 ms
Stdev: 2.7 ms (9.4%)
Runs: 32 32 30 30 29 28 28 27 27 23
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Performance test for Profile page Baseline
Mean: 6.7 ms
Stdev: 0.9 ms (14.2%)
Runs: 8 8 8 7 6 6 6 6 6 6

Current
Mean: 5.8 ms
Stdev: 0.4 ms (7.3%)
Runs: 6 6 6 6 6 6 6 6 5 5
Baseline
Mean: 5.70
Stdev: 2.21 (38.8%)
Runs: 12 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Bookings page Baseline
Mean: 38.5 ms
Stdev: 1.8 ms (4.8%)
Runs: 41 41 40 40 38 38 37 37 37 36

Current
Mean: 37.4 ms
Stdev: 1.3 ms (3.4%)
Runs: 39 39 38 38 38 37 37 37 36 35
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 15.1 ms
Stdev: 3.8 ms (25.1%)
Runs: 25 17 15 14 14 14 14 14 13 11

Current
Mean: 13.6 ms
Stdev: 1.3 ms (9.9%)
Runs: 15 15 15 14 14 14 13 13 12 11
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Offer page Baseline
Mean: 208.2 ms
Stdev: 6.3 ms (3.0%)
Runs: 222 214 210 210 208 206 206 203 202 201

Current
Mean: 203.8 ms
Stdev: 5.6 ms (2.7%)
Runs: 212 211 208 206 204 204 200 199 199 195
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Changes To Render Count

Name Render Duration Render Count
Performance test for Profile page 6.7 ms → 5.8 ms (-0.9 ms, -13.4%) 5.70 → 5 (-0.7000000000000002, -12.3%) 🟢
Show details
Name Render Duration Render Count
Performance test for Profile page Baseline
Mean: 6.7 ms
Stdev: 0.9 ms (14.2%)
Runs: 8 8 8 7 6 6 6 6 6 6

Current
Mean: 5.8 ms
Stdev: 0.4 ms (7.3%)
Runs: 6 6 6 6 6 6 6 6 5 5
Baseline
Mean: 5.70
Stdev: 2.21 (38.8%)
Runs: 12 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 388ff41

Copy link

sonarcloud bot commented Aug 9, 2024

Copy link

sonarcloud bot commented Aug 9, 2024

@Lucasbeneston Lucasbeneston merged commit 30f8584 into master Aug 9, 2024
52 checks passed
@Lucasbeneston Lucasbeneston deleted the PC-31095 branch August 9, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants