Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-31043) feat(categories): split "Films, séries et cinéma" search group #6859

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

thconte
Copy link
Contributor

@thconte thconte commented Sep 9, 2024

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-31043

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS
Android
Phone - Chrome
Desktop - Chrome

@thconte thconte force-pushed the thconte/poc-new-subcategories branch 2 times, most recently from dc6fc89 to a6f8c28 Compare September 10, 2024 07:48
Copy link

github-actions bot commented Sep 10, 2024

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for Bookings page 44.2 ms → 44.8 ms (+0.6 ms, +1.4%) 7 → 7
Performance test for Profile page 6.6 ms → 6.4 ms (-0.2 ms, -3.0%) 5 → 5
Performance test for Venue page 2.8 ms → 2.6 ms (-0.2 ms, -7.1%) 1 → 1
Search Results - Performance test for Search Results page 15.2 ms → 14.7 ms (-0.5 ms, -3.3%) 5 → 5
Performance test for EndedBookings page 35.2 ms → 34.6 ms (-0.6 ms, -1.7%) 7 → 7
Search Landing Page - Performance test for Search Landing page 14.4 ms → 13.3 ms (-1.1 ms, -7.6%) 5 → 5
Performance test for Favorites page 64.9 ms → 63.8 ms (-1.1 ms, -1.7%) 6 → 6
Performance test for Offer page 173.5 ms → 170.0 ms (-3.5 ms, -2.0%) 4 → 4
Show details
Name Render Duration Render Count
Performance test for Bookings page Baseline
Mean: 44.2 ms
Stdev: 2.6 ms (5.8%)
Runs: 48 47 46 46 45 44 42 42 41 41

Current
Mean: 44.8 ms
Stdev: 1.9 ms (4.3%)
Runs: 47 47 46 46 46 45 44 43 42 42
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Performance test for Profile page Baseline
Mean: 6.6 ms
Stdev: 0.8 ms (12.8%)
Runs: 8 7 7 7 7 7 6 6 6 5

Current
Mean: 6.4 ms
Stdev: 0.8 ms (13.2%)
Runs: 8 7 7 7 6 6 6 6 6 5
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Venue page Baseline
Mean: 2.8 ms
Stdev: 0.4 ms (15.1%)
Runs: 3 3 3 3 3 3 3 3 2 2

Current
Mean: 2.6 ms
Stdev: 0.5 ms (19.9%)
Runs: 3 3 3 3 3 3 2 2 2 2
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Search Results - Performance test for Search Results page Baseline
Mean: 15.2 ms
Stdev: 1.9 ms (12.7%)
Runs: 20 16 15 15 15 15 15 15 13 13

Current
Mean: 14.7 ms
Stdev: 1.1 ms (7.2%)
Runs: 16 16 16 15 15 14 14 14 14 13
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for EndedBookings page Baseline
Mean: 35.2 ms
Stdev: 1.2 ms (3.5%)
Runs: 37 36 36 36 36 35 35 34 34 33

Current
Mean: 34.6 ms
Stdev: 1.3 ms (3.7%)
Runs: 37 36 35 35 35 34 34 34 33 33
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 14.4 ms
Stdev: 1.1 ms (7.5%)
Runs: 16 15 15 15 15 14 14 14 14 12

Current
Mean: 13.3 ms
Stdev: 1.6 ms (12.3%)
Runs: 15 15 15 14 14 13 13 12 12 10
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Favorites page Baseline
Mean: 64.9 ms
Stdev: 2.1 ms (3.2%)
Runs: 68 67 66 66 65 65 65 63 63 61

Current
Mean: 63.8 ms
Stdev: 1.9 ms (3.0%)
Runs: 68 65 65 64 64 63 63 63 62 61
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Offer page Baseline
Mean: 173.5 ms
Stdev: 5.8 ms (3.3%)
Runs: 182 180 178 177 175 172 171 168 167 165

Current
Mean: 170.0 ms
Stdev: 7.4 ms (4.3%)
Runs: 178 178 177 175 170 170 167 166 164 155
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 0606ba5

@thconte thconte force-pushed the thconte/poc-new-subcategories branch 3 times, most recently from 927ba4f to 8c5e3b4 Compare September 12, 2024 09:24
@thconte thconte changed the title Split "Cinema, films et séries" search groups (PC-31042) feat(categories): split "Films, séries et cinéma" search group Sep 12, 2024
@thconte thconte force-pushed the thconte/poc-new-subcategories branch 2 times, most recently from 690facd to 3877c3d Compare September 16, 2024 10:34
@thconte thconte marked this pull request as ready for review September 16, 2024 10:35
@thconte thconte force-pushed the thconte/poc-new-subcategories branch from 3877c3d to f93485e Compare September 16, 2024 10:41
@thconte thconte changed the title (PC-31042) feat(categories): split "Films, séries et cinéma" search group (PC-31043) feat(categories): split "Films, séries et cinéma" search group Sep 16, 2024
@thconte thconte force-pushed the thconte/poc-new-subcategories branch 10 times, most recently from 734218a to 0705871 Compare September 18, 2024 16:52
Copy link

sonarcloud bot commented Sep 18, 2024

@thconte thconte force-pushed the thconte/poc-new-subcategories branch from 0705871 to 38c0a27 Compare September 19, 2024 15:17
@thconte thconte force-pushed the thconte/poc-new-subcategories branch from 38c0a27 to 0606ba5 Compare September 19, 2024 15:54
@thconte thconte requested review from a team as code owners September 19, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant