Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-30128) fix(global): Revert Vite for web app #6884

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

inesmouandjolobe
Copy link
Contributor

This reverts commit 7bd66f82d

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS
Android
Phone - Chrome
Desktop - Chrome

Copy link

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for EndedBookings page 33.6 ms → 34.8 ms (+1.2 ms, +3.6%) 7 → 7
Performance test for Venue page 2.4 ms → 2.6 ms (+0.2 ms, +8.3%) 1 → 1
Search Results - Performance test for Search Results page 14.8 ms → 14.9 ms (+0.1 ms, +0.7%) 5 → 5
Performance test for Profile page 6.7 ms → 6.3 ms (-0.4 ms, -6.0%) 5 → 5
Performance test for Offer page 176.7 ms → 175.5 ms (-1.2 ms, -0.7%) 4 → 4
Search Landing Page - Performance test for Search Landing page 14.7 ms → 13.5 ms (-1.2 ms, -8.2%) 5 → 5
Performance test for Favorites page 64.6 ms → 63.0 ms (-1.6 ms, -2.5%) 6 → 6
Performance test for Bookings page 47.5 ms → 45.0 ms (-2.5 ms, -5.3%) 7 → 7
Show details
Name Render Duration Render Count
Performance test for EndedBookings page Baseline
Mean: 33.6 ms
Stdev: 2.5 ms (7.3%)
Runs: 38 36 36 34 34 33 32 31 31 31

Current
Mean: 34.8 ms
Stdev: 1.1 ms (3.3%)
Runs: 37 36 35 35 35 35 34 34 34 33
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Performance test for Venue page Baseline
Mean: 2.4 ms
Stdev: 0.5 ms (21.5%)
Runs: 3 3 3 3 2 2 2 2 2 2

Current
Mean: 2.6 ms
Stdev: 0.5 ms (19.9%)
Runs: 3 3 3 3 3 3 2 2 2 2
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Search Results - Performance test for Search Results page Baseline
Mean: 14.8 ms
Stdev: 1.5 ms (10.5%)
Runs: 17 16 16 16 15 15 14 14 13 12

Current
Mean: 14.9 ms
Stdev: 1.4 ms (9.2%)
Runs: 17 16 16 16 15 15 14 14 13 13
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Profile page Baseline
Mean: 6.7 ms
Stdev: 0.8 ms (12.3%)
Runs: 8 8 7 7 7 6 6 6 6 6

Current
Mean: 6.3 ms
Stdev: 1.3 ms (19.9%)
Runs: 8 8 8 6 6 6 6 5 5 5
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Offer page Baseline
Mean: 176.7 ms
Stdev: 6.6 ms (3.7%)
Runs: 187 184 182 179 177 176 174 173 169 166

Current
Mean: 175.5 ms
Stdev: 10.2 ms (5.8%)
Runs: 202 178 178 177 173 172 171 170 167 167
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 14.7 ms
Stdev: 0.9 ms (6.5%)
Runs: 16 16 15 15 15 15 14 14 14 13

Current
Mean: 13.5 ms
Stdev: 1.0 ms (7.2%)
Runs: 15 15 14 14 13 13 13 13 13 12
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Favorites page Baseline
Mean: 64.6 ms
Stdev: 3.5 ms (5.4%)
Runs: 70 68 67 67 65 64 63 63 60 59

Current
Mean: 63.0 ms
Stdev: 2.3 ms (3.6%)
Runs: 66 66 65 65 62 62 62 61 61 60
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Bookings page Baseline
Mean: 47.5 ms
Stdev: 2.1 ms (4.5%)
Runs: 51 50 49 49 47 47 46 46 45 45

Current
Mean: 45.0 ms
Stdev: 3.4 ms (7.6%)
Runs: 49 49 48 47 47 44 43 42 41 40
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 602ec67

Copy link

sonarcloud bot commented Sep 13, 2024

Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 85%)

See analysis details on SonarCloud

Copy link
Contributor

@pierrecanthelou pierrecanthelou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants