Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32038) chore(ios): check XCode version before building #6935

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bruno-ebstein-pass-culture
Copy link
Contributor

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32038

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.

@bruno-ebstein-pass-culture bruno-ebstein-pass-culture changed the title (PC-32038) chore(ios): refactor DRY react-native run-ios (PC-32038) chore(ios): check XCode version before building Sep 26, 2024
Copy link

sonarcloud bot commented Sep 26, 2024

Copy link

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for EndedBookings page 30.3 ms → 31.0 ms (+0.7 ms, +2.3%) 6 → 6
Performance test for Bookings page 60.6 ms → 61.3 ms (+0.7 ms, +1.2%) 9 → 9
Performance test for Venue page 2.5 ms → 2.5 ms 1 → 1
Performance test for Profile page 6.9 ms → 6.9 ms 5 → 5
Search Results - Performance test for Search Results page 14.4 ms → 14.0 ms (-0.4 ms, -2.8%) 5 → 5
Performance test for Offer page 172.5 ms → 171.8 ms (-0.7 ms, ±0.0%) 4 → 4
Performance test for Favorites page 64.6 ms → 63.3 ms (-1.3 ms, -2.0%) 6 → 6
Search Landing Page - Performance test for Search Landing page 14.8 ms → 13.5 ms (-1.3 ms, -8.8%) 5 → 5
Show details
Name Render Duration Render Count
Performance test for EndedBookings page Baseline
Mean: 30.3 ms
Stdev: 1.4 ms (4.7%)
Runs: 32 32 32 31 30 30 30 29 29 28

Current
Mean: 31.0 ms
Stdev: 1.7 ms (5.5%)
Runs: 33 33 32 32 32 31 30 30 29 28
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Bookings page Baseline
Mean: 60.6 ms
Stdev: 2.5 ms (4.1%)
Runs: 65 63 62 62 61 60 59 59 58 57

Current
Mean: 61.3 ms
Stdev: 2.5 ms (4.1%)
Runs: 65 64 64 62 62 61 59 59 59 58
Baseline
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9

Current
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9
Performance test for Venue page Baseline
Mean: 2.5 ms
Stdev: 0.5 ms (21.1%)
Runs: 3 3 3 3 3 2 2 2 2 2

Current
Mean: 2.5 ms
Stdev: 0.7 ms (28.3%)
Runs: 3 3 3 3 3 3 2 2 2 1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Performance test for Profile page Baseline
Mean: 6.9 ms
Stdev: 0.7 ms (10.7%)
Runs: 8 8 7 7 7 7 7 6 6 6

Current
Mean: 6.9 ms
Stdev: 1.0 ms (14.4%)
Runs: 9 8 7 7 7 7 6 6 6 6
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Search Results - Performance test for Search Results page Baseline
Mean: 14.4 ms
Stdev: 1.6 ms (11.0%)
Runs: 16 16 16 15 15 15 14 13 12 12

Current
Mean: 14.0 ms
Stdev: 2.1 ms (15.1%)
Runs: 17 17 16 15 14 13 12 12 12 12
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Offer page Baseline
Mean: 172.5 ms
Stdev: 8.2 ms (4.8%)
Runs: 187 182 179 175 174 169 167 165 164 163

Current
Mean: 171.8 ms
Stdev: 6.7 ms (3.9%)
Runs: 182 180 179 173 172 170 169 165 164 164
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Performance test for Favorites page Baseline
Mean: 64.6 ms
Stdev: 3.1 ms (4.9%)
Runs: 71 67 67 65 65 64 63 62 61 61

Current
Mean: 63.3 ms
Stdev: 2.3 ms (3.7%)
Runs: 66 66 65 65 64 64 61 61 61 60
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 14.8 ms
Stdev: 1.5 ms (10.0%)
Runs: 17 16 16 15 15 15 15 14 13 12

Current
Mean: 13.5 ms
Stdev: 1.6 ms (12.2%)
Runs: 16 15 15 15 13 13 13 12 12 11
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against b3857d5

Copy link

sonarcloud bot commented Sep 26, 2024

"ios:prod": "react-native run-ios --scheme PassCulture-Production",
"ios:staging": "react-native run-ios --scheme PassCulture-Staging",
"ios:testing": "react-native run-ios --scheme PassCulture-Testing",
"preios": "./scripts/check_xcode_version.sh",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"preios": "./scripts/check_xcode_version.sh",
"preios": "./scripts/check_xcode_version.sh",

on pourrait imaginer une commande yarn doctor ou yarn checkup qui vérifie les problèmes connus sur le set up de dev au delà d'xcode

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attention, le nom de commit suggère que cette vérification est appelée avant d'appeler yarn ios:* ce qui n'est pas le cas

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

le nom de commit suggère que cette vérification est appelée avant d'appeler yarn ios:* ce qui n'est pas le cas

pourquoi ça ne serait pas le cas ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants