-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PC-32038) chore(ios): check XCode version before building #6935
base: master
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
Performance Comparison ReportSignificant Changes To Render DurationThere are no entries Meaningless Changes To Render DurationShow entries
Show details
Changes To Render CountThere are no entries Added ScenariosThere are no entries Removed ScenariosThere are no entries |
Quality Gate passedIssues Measures |
"ios:prod": "react-native run-ios --scheme PassCulture-Production", | ||
"ios:staging": "react-native run-ios --scheme PassCulture-Staging", | ||
"ios:testing": "react-native run-ios --scheme PassCulture-Testing", | ||
"preios": "./scripts/check_xcode_version.sh", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"preios": "./scripts/check_xcode_version.sh", | |
"preios": "./scripts/check_xcode_version.sh", |
on pourrait imaginer une commande yarn doctor
ou yarn checkup
qui vérifie les problèmes connus sur le set up de dev au delà d'xcode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attention, le nom de commit suggère que cette vérification est appelée avant d'appeler yarn ios:*
ce qui n'est pas le cas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
le nom de commit suggère que cette vérification est appelée avant d'appeler yarn ios:* ce qui n'est pas le cas
pourquoi ça ne serait pas le cas ?
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32038
Flakiness
If I had to re-run tests in the CI due to flakiness, I add the incident on Notion
Checklist
I have: