Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-31869) feat(XpCine): filter cinema by day #6940

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xlecunff-pass
Copy link
Contributor

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-XXXXX

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

delete if no UI change

Platform Mockup/Before After
iOS
Android
Phone - Chrome
Desktop - Chrome

Copy link

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for EndedBookings page 31.2 ms → 31.3 ms (+0.1 ms, ±0.0%) 6 → 6
Performance test for Profile page 6.6 ms → 6.7 ms (+0.1 ms, +1.5%) 5 → 5
Performance test for Venue page 2.4 ms → 2.5 ms (+0.1 ms, +4.2%) 1 → 1
Search Results - Performance test for Search Results page 13.9 ms → 13.5 ms (-0.4 ms, -2.9%) 5 → 5
Search Landing Page - Performance test for Search Landing page 14.8 ms → 14.4 ms (-0.4 ms, -2.7%) 5 → 5
Performance test for Offer page 175.8 ms → 174.9 ms (-0.9 ms, -0.5%) 4 → 4
Performance test for Favorites page 65.3 ms → 64.1 ms (-1.2 ms, -1.8%) 6 → 6
Performance test for Bookings page 63.8 ms → 61.0 ms (-2.8 ms, -4.4%) 9 → 9
Show details
Name Render Duration Render Count
Performance test for EndedBookings page Baseline
Mean: 31.2 ms
Stdev: 1.5 ms (5.0%)
Runs: 34 32 32 32 32 31 31 30 29 29

Current
Mean: 31.3 ms
Stdev: 1.8 ms (5.6%)
Runs: 34 33 33 32 31 31 31 30 30 28
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Profile page Baseline
Mean: 6.6 ms
Stdev: 0.8 ms (12.8%)
Runs: 8 7 7 7 7 7 6 6 6 5

Current
Mean: 6.7 ms
Stdev: 0.8 ms (12.3%)
Runs: 8 7 7 7 7 7 7 6 6 5
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Venue page Baseline
Mean: 2.4 ms
Stdev: 0.7 ms (29.1%)
Runs: 3 3 3 3 3 2 2 2 2 1

Current
Mean: 2.5 ms
Stdev: 0.5 ms (21.1%)
Runs: 3 3 3 3 3 2 2 2 2 2
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Search Results - Performance test for Search Results page Baseline
Mean: 13.9 ms
Stdev: 1.5 ms (11.0%)
Runs: 16 15 15 15 14 14 14 13 12 11

Current
Mean: 13.5 ms
Stdev: 1.4 ms (10.6%)
Runs: 15 15 15 14 14 14 13 12 12 11
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 14.8 ms
Stdev: 1.5 ms (10.0%)
Runs: 17 16 16 16 15 15 14 13 13 13

Current
Mean: 14.4 ms
Stdev: 1.0 ms (6.7%)
Runs: 16 15 15 15 15 14 14 14 13 13
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Offer page Baseline
Mean: 175.8 ms
Stdev: 3.3 ms (1.9%)
Runs: 180 179 179 178 178 174 173 173 173 171

Current
Mean: 174.9 ms
Stdev: 7.0 ms (4.0%)
Runs: 190 180 179 178 175 171 171 170 168 167
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Performance test for Favorites page Baseline
Mean: 65.3 ms
Stdev: 2.7 ms (4.1%)
Runs: 71 67 66 66 66 65 64 64 63 61

Current
Mean: 64.1 ms
Stdev: 2.2 ms (3.5%)
Runs: 68 67 66 64 64 63 63 63 62 61
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Bookings page Baseline
Mean: 63.8 ms
Stdev: 3.1 ms (4.8%)
Runs: 69 67 66 64 64 63 63 63 61 58

Current
Mean: 61.0 ms
Stdev: 3.2 ms (5.2%)
Runs: 64 64 63 63 62 62 61 60 56 55
Baseline
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9

Current
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 63f4027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant