Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32103) feat(venueMap): add prop to hide points of interest #6961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmeissonnier-pass
Copy link
Contributor

@mmeissonnier-pass mmeissonnier-pass commented Oct 4, 2024

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32103

Ajout d'une prop permettant de masquer différents lieux inutiles pour soulager la carte visuellement

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

Android:
image

iOS :
image

Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

github-actions bot commented Oct 4, 2024

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for Offer page 171.7 ms → 173.3 ms (+1.6 ms, +0.9%) 4 → 4
Search Results - Performance test for Search Results page 14.3 ms → 14.8 ms (+0.5 ms, +3.5%) 5 → 5
Performance test for Venue page 2.5 ms → 2.8 ms (+0.3 ms, +12.0%) 2 → 2
Performance test for Profile page 6.3 ms → 6.2 ms (-0.1 ms, -1.6%) 5.70 → 5 (-0.7000000000000002, -12.3%) 🟢
Performance test for EndedBookings page 30.4 ms → 30.0 ms (-0.4 ms, -1.3%) 6 → 6
Performance test for Favorites page 64.6 ms → 64.0 ms (-0.6 ms, -0.9%) 6 → 6
Performance test for Bookings page 62.1 ms → 61.4 ms (-0.7 ms, -1.1%) 9 → 9
Search Landing Page - Performance test for Search Landing page 14.9 ms → 13.7 ms (-1.2 ms, -8.1%) 5 → 5
Show details
Name Render Duration Render Count
Performance test for Offer page Baseline
Mean: 171.7 ms
Stdev: 4.2 ms (2.5%)
Runs: 179 178 173 172 172 171 170 169 167 166

Current
Mean: 173.3 ms
Stdev: 5.7 ms (3.3%)
Runs: 180 179 178 175 175 175 174 168 165 164
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Search Results - Performance test for Search Results page Baseline
Mean: 14.3 ms
Stdev: 1.6 ms (11.0%)
Runs: 17 16 15 15 15 14 13 13 13 12

Current
Mean: 14.8 ms
Stdev: 0.8 ms (5.3%)
Runs: 16 16 15 15 15 15 14 14 14 14
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Venue page Baseline
Mean: 2.5 ms
Stdev: 0.7 ms (28.3%)
Runs: 4 3 3 3 2 2 2 2 2 2

Current
Mean: 2.8 ms
Stdev: 0.8 ms (28.2%)
Runs: 4 4 3 3 3 3 2 2 2 2
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Performance test for Profile page Baseline
Mean: 6.3 ms
Stdev: 0.9 ms (15.1%)
Runs: 8 7 7 7 6 6 6 6 5 5

Current
Mean: 6.2 ms
Stdev: 1.5 ms (25.0%)
Runs: 9 7 7 7 7 6 6 5 4 4
Baseline
Mean: 5.70
Stdev: 2.21 (38.8%)
Runs: 12 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for EndedBookings page Baseline
Mean: 30.4 ms
Stdev: 1.6 ms (5.2%)
Runs: 32 32 32 31 31 31 30 29 28 28

Current
Mean: 30.0 ms
Stdev: 1.9 ms (6.3%)
Runs: 34 32 30 30 30 30 29 29 29 27
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Favorites page Baseline
Mean: 64.6 ms
Stdev: 2.6 ms (4.1%)
Runs: 70 68 66 64 64 64 63 63 62 62

Current
Mean: 64.0 ms
Stdev: 2.0 ms (3.1%)
Runs: 67 66 66 65 64 64 63 62 62 61
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Performance test for Bookings page Baseline
Mean: 62.1 ms
Stdev: 2.0 ms (3.2%)
Runs: 65 65 63 63 62 62 61 61 60 59

Current
Mean: 61.4 ms
Stdev: 3.1 ms (5.1%)
Runs: 69 63 62 62 61 61 60 60 58 58
Baseline
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9

Current
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 14.9 ms
Stdev: 1.3 ms (8.6%)
Runs: 16 16 16 16 16 15 14 14 13 13

Current
Mean: 13.7 ms
Stdev: 1.1 ms (7.7%)
Runs: 15 15 15 14 14 13 13 13 13 12
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Changes To Render Count

Name Render Duration Render Count
Performance test for Profile page 6.3 ms → 6.2 ms (-0.1 ms, -1.6%) 5.70 → 5 (-0.7000000000000002, -12.3%) 🟢
Show details
Name Render Duration Render Count
Performance test for Profile page Baseline
Mean: 6.3 ms
Stdev: 0.9 ms (15.1%)
Runs: 8 7 7 7 6 6 6 6 5 5

Current
Mean: 6.2 ms
Stdev: 1.5 ms (25.0%)
Runs: 9 7 7 7 7 6 6 5 4 4
Baseline
Mean: 5.70
Stdev: 2.21 (38.8%)
Runs: 12 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 5d4ff4c

Copy link

sonarcloud bot commented Oct 4, 2024

@mmeissonnier-pass mmeissonnier-pass marked this pull request as ready for review October 4, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant