Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-32207) fix(Search): locationWidget on web mobile should be on th… #6966

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NolwenMajorFrances
Copy link
Contributor

@NolwenMajorFrances NolwenMajorFrances commented Oct 4, 2024

…e right

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-32207

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

delete if no UI change

Platform Mockup/Before After
Phone - Chrome image Capture d’écran 2024-10-04 à 17 23 42
Desktop - Chrome ( je montre juste que ça fonctionne toujours en web grand ecran) Capture d’écran 2024-10-04 à 17 24 42 Capture d’écran 2024-10-04 à 17 24 02

@NolwenMajorFrances NolwenMajorFrances changed the title (PC-32207) fix(Search) : locationWidget on web mobile should be on th… (PC-32207) fix(Search): locationWidget on web mobile should be on th… Oct 4, 2024
@NolwenMajorFrances NolwenMajorFrances marked this pull request as ready for review October 4, 2024 15:25
Copy link

github-actions bot commented Oct 4, 2024

Performance Comparison Report

Significant Changes To Render Duration

There are no entries

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for Favorites page 64.2 ms → 65.2 ms (+1.0 ms, +1.6%) 6 → 6
Search Results - Performance test for Search Results page 14.1 ms → 13.9 ms (-0.2 ms, -1.4%) 5 → 5
Performance test for Bookings page 61.9 ms → 61.5 ms (-0.4 ms, -0.6%) 9 → 9
Performance test for Venue page 3.1 ms → 2.7 ms (-0.4 ms, -12.9%) 2 → 2
Search Landing Page - Performance test for Search Landing page 14.5 ms → 14.1 ms (-0.4 ms, -2.8%) 5 → 5
Performance test for Offer page 173.5 ms → 172.9 ms (-0.6 ms, ±0.0%) 4 → 4
Performance test for Profile page 7.1 ms → 6.4 ms (-0.7 ms, -9.9%) 5 → 5
Performance test for EndedBookings page 30.5 ms → 29.7 ms (-0.8 ms, -2.6%) 6 → 6
Show details
Name Render Duration Render Count
Performance test for Favorites page Baseline
Mean: 64.2 ms
Stdev: 2.2 ms (3.4%)
Runs: 68 67 66 64 64 64 63 63 62 61

Current
Mean: 65.2 ms
Stdev: 1.7 ms (2.6%)
Runs: 68 67 66 66 66 65 64 64 63 63
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6
Search Results - Performance test for Search Results page Baseline
Mean: 14.1 ms
Stdev: 0.7 ms (5.2%)
Runs: 15 15 15 14 14 14 14 14 13 13

Current
Mean: 13.9 ms
Stdev: 1.5 ms (11.0%)
Runs: 16 16 15 14 14 14 13 13 13 11
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Bookings page Baseline
Mean: 61.9 ms
Stdev: 3.1 ms (5.0%)
Runs: 67 65 65 63 62 61 61 59 58 58

Current
Mean: 61.5 ms
Stdev: 2.4 ms (3.9%)
Runs: 65 63 63 63 62 62 61 61 58 57
Baseline
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9

Current
Mean: 9
Stdev: 0 (0.0%)
Runs: 9 9 9 9 9 9 9 9 9 9
Performance test for Venue page Baseline
Mean: 3.1 ms
Stdev: 0.7 ms (23.8%)
Runs: 4 4 4 3 3 3 3 3 2 2

Current
Mean: 2.7 ms
Stdev: 0.7 ms (25.0%)
Runs: 4 3 3 3 3 3 2 2 2 2
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 14.5 ms
Stdev: 1.4 ms (9.3%)
Runs: 16 16 16 15 15 14 14 14 13 12

Current
Mean: 14.1 ms
Stdev: 1.4 ms (10.3%)
Runs: 16 16 15 15 14 14 14 13 12 12
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Offer page Baseline
Mean: 173.5 ms
Stdev: 5.7 ms (3.3%)
Runs: 185 180 177 174 172 172 170 170 168 167

Current
Mean: 172.9 ms
Stdev: 2.7 ms (1.6%)
Runs: 177 176 175 174 173 173 172 170 170 169
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Performance test for Profile page Baseline
Mean: 7.1 ms
Stdev: 1.0 ms (14.0%)
Runs: 9 8 8 7 7 7 7 6 6 6

Current
Mean: 6.4 ms
Stdev: 0.8 ms (13.2%)
Runs: 8 7 7 7 6 6 6 6 6 5
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for EndedBookings page Baseline
Mean: 30.5 ms
Stdev: 2.2 ms (7.1%)
Runs: 34 33 32 32 30 30 29 29 29 27

Current
Mean: 29.7 ms
Stdev: 1.2 ms (3.9%)
Runs: 32 31 30 30 30 29 29 29 29 28
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 21f2460

Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

sonarcloud bot commented Oct 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant