Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: updates phone number due to conflict with other test data #84

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Sep 5, 2024

What originally prompted this change is that the auth token being used for the tests expired. Since the GHA secrets weren't backed anywhere I had to update them all with ones that we bootstrapped earlier today (and back them up).

Changes:

  • updates the GHA secrets with new test resource ids
  • updates the expected device count for the new test user
  • updates the phone number used in the update user test to deconflict with existing phone numbers from old test runs
    • this one is a short-term fix. the longer-term fix is more idempotent test scaffolding to be done in a separate effort

… is a short-term fix)

also updates the expected device count based on the new bootstrapped test user
@ctran88 ctran88 requested a review from a team September 5, 2024 01:08
@ctran88 ctran88 merged commit f28b175 into main Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants