Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing publint error and warning #153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikecousins
Copy link

@mikecousins mikecousins commented Sep 4, 2024

The types field needs to be first in the exports object and no type is specified. This should fix all of the publint issues for the package.

Reference: https://publint.dev/@passageidentity/[email protected]

The types field needs to be first in the exports object and no type is specified. This should fix all of the publint issues for the package.
Copy link

sonarcloud bot commented Sep 4, 2024

@flanagankp
Copy link
Contributor

@mikecousins I'll take a look at this PR soon, thanks for looking into this.

@flanagankp
Copy link
Contributor

flanagankp commented Sep 23, 2024

@mikecousins I've finally had a chance to take a look at this PR and it makes sense to me. I've also validated this place nicely with some common test apps, in particular ones that have been a little tricky in the past, namely:

  • Next.js
  • Remix
  • Sveltekit
  • The classic Express app

To actually merge this PR in you'll also need to add a changefile - we use a tool called beachball for semantic versioning. If you run npm run change on this branch you'll be guided through a dialog to set the type of change (just a patch), and add a note about the change that will get included in our changelog. The PR validation action will return an error until this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants