Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added integration tests #11

Merged
merged 10 commits into from
Sep 11, 2024
Merged

Added integration tests #11

merged 10 commits into from
Sep 11, 2024

Conversation

rickycpadilla
Copy link
Collaborator

@rickycpadilla rickycpadilla commented Sep 10, 2024

What's New?

  • Added integration tests
  • Other changes
    • Finished Passage class
    • Improved keychain service methods
    • Added currentUser.logOut method

Screenshots (if appropriate):

Please attach any screenshots that would help illustrate the changes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Jira Ticket

Please add the Jira ticket number and link.

Additional context

⚠️ There are two sets of tests coming in a follow-up PR

  • token store tests
  • hosted auth tests

@rickycpadilla rickycpadilla requested a review from a team as a code owner September 10, 2024 16:42
@rickycpadilla rickycpadilla merged commit 53c1e36 into main Sep 11, 2024
@rickycpadilla rickycpadilla deleted the PSG-4348-integration-tests branch September 11, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants