Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Adding SSL configuration for mysql/mariadb - passbolt_api/pull/275 #111

Merged
merged 2 commits into from
Oct 15, 2018
Merged

✨ Adding SSL configuration for mysql/mariadb - passbolt_api/pull/275 #111

merged 2 commits into from
Oct 15, 2018

Conversation

bakayolo
Copy link
Contributor

@bakayolo bakayolo commented Aug 4, 2018 •
edited
Loading

Blocked by passbolt/passbolt_api#275, I just modified the README.md to add the information about Database Mutual SSL configuration.

@dlen dlen self-assigned this Aug 7, 2018
@dlen
Copy link
Member

dlen commented Aug 7, 2018 •
edited
Loading

Hi @bappr !

Thanks for your interest in the project! The PR is fine just when it's solved on passbolt_api we can merge it.
I just noticed that the environment variables don't follow passbolt config files convention. I think it should be:

DATASOURCES_DEFAULT_SSL_KEY
DATASOURCES_DEFAULT_SSL_CERT
DATASOURCES_DEFAULT_SSL_CA

Other than that it LGTM

@bakayolo
Copy link
Contributor Author

bakayolo commented Aug 7, 2018

Hi @dlen
Indeed you re right, I just updated both PR.

@dlen dlen added the blocked label Aug 8, 2018
@dlen dlen merged commit 9321579 into passbolt:master Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dlen dlen

Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bakayolo @dlen