Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removeFirstOrNull #173

Merged
merged 5 commits into from
Oct 31, 2021
Merged

Conversation

Dev-dfm
Copy link
Contributor

@Dev-dfm Dev-dfm commented Oct 14, 2021

fixes #159 removeFirstOrNull

@Dev-dfm Dev-dfm requested a review from passsy October 15, 2021 17:41
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #173 (35337cd) into master (b29dc21) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 35337cd differs from pull request most recent head ecd5f69. Consider uploading reports for the commit ecd5f69 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files          40       40           
  Lines        1843     1847    +4     
=======================================
+ Hits         1826     1830    +4     
  Misses         17       17           
Flag Coverage Δ
unittests 99.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/src/collection/impl/list_mutable.dart 100.00% <ø> (ø)
lib/src/collection/kt_list_mutable.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29dc21...ecd5f69. Read the comment docs.

@passsy
Copy link
Owner

passsy commented Oct 16, 2021

Please make sure to have a minimum diff. It makes it unnecessary noisey to review unrelated formatting changes.

@passsy
Copy link
Owner

passsy commented Oct 31, 2021

While checking the kotlin implementation I noticed that removeFirst/removeLast were accidentally defined as members of KtMutableList not as extension. Changed that and added removeLastOrNull as well

@passsy passsy force-pushed the feature/remove_first_or_null branch from 35337cd to ecd5f69 Compare October 31, 2021 16:08
@passsy passsy merged commit f173b94 into passsy:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add removeFirstOrNull
2 participants