Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Become fully Dart 2.0 compatible #96

Merged
merged 4 commits into from
Apr 23, 2019
Merged

Become fully Dart 2.0 compatible #96

merged 4 commits into from
Apr 23, 2019

Conversation

passsy
Copy link
Owner

@passsy passsy commented Apr 23, 2019

I noticed that ktdart wasn't working in dart 2.0. Only minor changes where required to fix this.

To prevent such regressions I changed the CI setup to run on all supported dart versions

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #96 into master will decrease coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   99.84%   99.63%   -0.21%     
==========================================
  Files          41       42       +1     
  Lines        1923     1940      +17     
==========================================
+ Hits         1920     1933      +13     
- Misses          3        7       +4
Impacted Files Coverage Δ
...rc/collection/impl/dart_unmodifiable_set_view.dart 100% <ø> (ø) ⬆️
lib/src/collection/impl/list_empty.dart 100% <ø> (ø) ⬆️
lib/src/collection/impl/map_empty.dart 100% <ø> (ø) ⬆️
lib/src/collection/impl/map_mutable.dart 100% <ø> (ø) ⬆️
lib/src/collection/impl/set.dart 100% <ø> (ø) ⬆️
lib/src/collection/impl/set_mutable.dart 100% <ø> (ø) ⬆️
lib/src/collection/impl/map.dart 100% <ø> (ø) ⬆️
lib/src/collection/impl/set_empty.dart 100% <ø> (ø) ⬆️
lib/src/collection/impl/list.dart 100% <ø> (ø) ⬆️
lib/src/collection/impl/list_mutable.dart 100% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3f069...1f67ec8. Read the comment docs.

@passsy passsy merged commit 168ce62 into master Apr 23, 2019
@passsy passsy deleted the feature/dart2.0 branch April 23, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant