Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak #333

Closed
mohammadalijf opened this issue Mar 5, 2017 · 10 comments
Closed

Memory Leak #333

mohammadalijf opened this issue Mar 5, 2017 · 10 comments

Comments

@mohammadalijf
Copy link

hi, im using your pod in my project to create a simple calendar and im using latest version.
the problem is when i use instrument to check my leaks i've got lots of memory leak from the pod.
i also tried the example project still got memory leaks.
the following screen shot is from profiling the example project.
screen shot 2017-03-05 at 9 48 57 am

@patchthecode
Copy link
Owner

checking this now.

@patchthecode
Copy link
Owner

patchthecode commented Mar 6, 2017

Leaks fixed -> f376372

One more leak to fix. Occurs on initial load and on layout change.

@patchthecode
Copy link
Owner

Seems that the final leak is an Apple Bug.

Looking for a work around now.

patchthecode added a commit that referenced this issue Mar 7, 2017
@patchthecode
Copy link
Owner

All leaks fixed.

@mohammadalijf
Copy link
Author

thank you. i will test master branch and report back

@patchthecode
Copy link
Owner

@mohammadalijf I have a weird iss that i am looking into however.

I use XCode 8.3 Beta, iOS 10.3 and there are no leaks.

But When I use Xcode 8.2, iOS 10.2, there are leaks.
Also I found an XCode bug causing the leaks (i have shown you the link above).

I am now looking into why there are leaks for iOS 10.2 Xcode 8.2

@mohammadalijf
Copy link
Author

still got UIDeviceRGBColor leak which is somehow normal because swift will cache colors for future usage (mostly instrument bug i guess).
also i found some weird leaks when i'm using arrays and dictionaries with Xcode 8.2
you can find these kind of leaks in pods like Alamofire etc.

i guess we should wait for Xcode 8.3 till we get a totally leak free apps.

@patchthecode
Copy link
Owner

patchthecode commented Mar 8, 2017

I believe so.
Because I can assure you that Xcode 8.3 with JTAppleCalendar has no leaks on master branch

@mohammadalijf
Copy link
Author

thank you for such a quick issue fix

@patchthecode
Copy link
Owner

closing issue
released 6.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants