Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Husky consolidation and v5 #53

Closed
ccorda opened this issue Nov 28, 2020 · 3 comments · Fixed by #179
Closed

Husky consolidation and v5 #53

ccorda opened this issue Nov 28, 2020 · 3 comments · Fixed by #179

Comments

@ccorda
Copy link
Contributor

ccorda commented Nov 28, 2020

Traditionally in bubs, we had husky perform two checks:

  1. see if the yarn.lock changed, and if so let dev know they need to run yarn install
  2. set chmod permissions on acf json

Now that we have both wp and wordpress with their own package.json files, we're in a little bit of trouble.

We also want to add in linting as a pre-commit hook on our website folder.

Husky has also updated to version 5 which works a little differently:
https://typicode.github.io/husky/#/?id=usage

My recommendation would be to:

  • Update to Husky version 5
  • Remove Susky from wordpress
  • Have Husky live inside of website
@ccorda ccorda mentioned this issue Dec 1, 2020
@kylehotchkiss
Copy link
Member

@ccorda I got this error when git pulling one of our projects today:

husky > post-merge hook failed (cannot be bypassed with --no-verify due to Git specs)``` 

Is this related or should I file a new ticket?

@ccorda
Copy link
Contributor Author

ccorda commented Apr 6, 2021

Looks like they're up to 6 now, and hopefully it fixes some of the issues that 5 had. Still leaving us on 4 for now:
https://typicode.github.io/husky/#/?id=migrate-from-v4-to-v6

@kylehotchkiss
Copy link
Member

@ccorda ccorda linked a pull request Nov 19, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants