-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bumping husky to version 7 #179
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/patronage/bubs-next/D5aBv33siASvWYYRCFLx9F1GR415 |
I get an error about file executable flags (I don't think we have our local git setup to track file flags). Can you try removing your repo, recloning, and seeing if you can replicate?
|
Thanks Kyle. Tried on a totally fresh install, and now it works (successfully installing as executables as a part of the prepare step on first commit) |
@kylehotchkiss green now, can you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just re-cloned and husky is now working as expected
* main: feat: bumping husky to version 7 (#179) # Conflicts: # website/package.json # website/yarn.lock
* main: simpler eslint config (no custom babel) (#185) chore: node minor dep upgrades (#188) docs: env variable with graphcdn fix bug in postheader loading wrong scss file fix env.sample domain for graphcdn fix: meta not respecting social variables, customized title (#176) feat: log wp admin users into front-end preview mode (#173) fix: Get stylelint working again (#182) feat: Next 12 upgrade (#180) feat: bumping husky to version 7 (#179) resolve bug where clicking 'view' in wp-admin leads to a broken redirect (#165) feat: new convenience plugins in wordpress admin (#166) feat: theme mod instead of acf options for preview mode url (#163)
To test:
cd website
yarn install
You should see the following, and you won't get to the commit stage.