Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugin prettier/recommended from .eslintrc #95

Closed
imjared opened this issue Apr 16, 2021 · 3 comments
Closed

Remove plugin prettier/recommended from .eslintrc #95

imjared opened this issue Apr 16, 2021 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@imjared
Copy link

imjared commented Apr 16, 2021

Part of the benefit of Prettier it is that it runs automatically, allowing the dev to code with whatever style looks/feels right at the moment then on commit, code gets standardized. Prettier errors via eslint are not only unnecessary but are distracting during development as they get mixed in with actual eslint errors and warnings.

Example:

@imjared imjared added the enhancement New feature or request label Apr 16, 2021
@ccorda ccorda added this to the 1.0 milestone Aug 9, 2021
@ccorda
Copy link
Contributor

ccorda commented Aug 25, 2021

Reviewing 1.0 issues and trying to understand this one...

https://nextjs.org/docs/basic-features/eslint#usage-with-prettier

ESLint also contains code formatting rules, which can conflict with your existing Prettier setup. We recommend including eslint-config-prettier in your ESLint config to make ESLint and Prettier work together.

Are you ok leaving eslint-config-prettier, but then removing eslint-plugin-prettier? I've submitted a PR #145 to test this approach out.

@ccorda
Copy link
Contributor

ccorda commented Sep 28, 2021

One regression I just realized, we had VSCode configured to disable prettier, and run eslint fix on save. We need to adjust that if we're going this route.

ccorda added a commit that referenced this issue Oct 5, 2021
@ccorda
Copy link
Contributor

ccorda commented Nov 26, 2021

Recently upgraded stylelint and eslint, believe we are all good here.

@ccorda ccorda closed this as completed Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants