Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: define initial viewport #1386

Merged
merged 1 commit into from
Dec 3, 2021
Merged

feat: define initial viewport #1386

merged 1 commit into from
Dec 3, 2021

Conversation

mfranzke
Copy link
Contributor

Closes #1385

Summary of changes:

Added the configuration option to deactivate resizing of the viewport according to the persisted viewport decisions the users have made previously. In the future we might even allow values in here instead of just a boolean.

I've decided to not prevent the persistence both for backwards compatibility as well as providing the possibility for a temporary or subpath specific setting, where we might not want to influence the persistence itself.

@JosefBredereck JosefBredereck merged commit 6fa630e into pattern-lab:dev Dec 3, 2021
@mfranzke mfranzke deleted the feat/default-InitialWidth branch December 3, 2021 20:31
mfranzke added a commit to mfranzke/patternlab-node that referenced this pull request Dec 4, 2021
@mfranzke
feat: define initial viewport (pattern-lab#1386)
eae2087
JosefBredereck pushed a commit that referenced this pull request Dec 4, 2021
@mfranzke
refactor: updated lerna dependency (#1382)
91d2d3e 
* chore(docs): some typos

missed to replace mustache initially and incorrect handlebars two times (both in package name and URL)

* Revert "Merge pull request #2 from pattern-lab/dev"

This reverts commit 7812878, reversing
changes made to 26db979.

* Revert "Merge pull request #1 from pattern-lab/dev"

This reverts commit 26db979, reversing
changes made to fc90750.

* Revert "chore(docs): some typos"

This reverts commit 271dc8d.

* refactor: updated lerna dependency

executed a simple migration script as stated in https://github.com/lerna/lerna/blob/main/CHANGELOG.md#400-2021-02-10

* chore: formatting

* chore: code optimizations

that are mentioned by the github pipeline as well

* chore: formatting

* Revert "chore: formatting"

This reverts commit 60a3d64.

* chore:formatting

* chore: formatting

* Revert "Merge branch 'dev' into refactor/updated-lerna-dependency"

This reverts commit ab5e103, reversing
changes made to e7123c1.

* Revert "chore: formatting"

This reverts commit e7123c1.

* chore: formatting

* Revert "Revert "Merge branch 'dev' into refactor/updated-lerna-dependency""

This reverts commit ed365ea.

* Revert "Revert "Revert "Merge branch 'dev' into refactor/updated-lerna-dependency"""

This reverts commit 2c27360.

* refactor: moved dependencies to devDependencies @ cli (#1384)

* refactor: moved dependencies to devDependencies

* build: regenerated package-lock.json

* chore: reformatting

* chore: code optimizations

that are mentioned by the github pipeline as well

* Revert "chore: reformatting"

This reverts commit a5cfdd5.

* build: regenerated package-lock.json

* refactor: updated 11ty dependencies (#1383)

* refactor: updated 11ty dependencies

* Revert "refactor: updated 11ty dependencies"

This reverts commit f9743ed.

* build: updated @11ty/eleventy-plugin-rss dependency

* chore: formatting

* chore: code optimizations

that are mentioned by the github pipeline as well

* Revert "chore: formatting"

This reverts commit 8abf6fc.

* build: updated @11ty/eleventy-navigation dependency

* chore: formatting

* build: updated @11ty/eleventy-plugin-syntaxhighlight dependency

* Revert "chore: formatting"

This reverts commit cd323e7.

* build: updated @11ty/eleventy dependency

* chore: formattingbuild: updated @11ty/eleventy dependency

* build: regenerated package-lock.json

* build: regenerated yarn.lock

* feat: define initial viewport (#1386)

* refactor: updated http-auth dependency (#1379)

* refactor: updated http-auth dependency
http-auth: added necessary new dependency http-auth-connect that provides the method .connect that got extracted from the original one.
* chore: formatting
* chore: code optimizations
that are mentioned by the github pipeline as well
* Revert "chore: formatting"
This reverts commit 5b7a95b.

* chore: adding simple pattern descriptions (#1378)

* chore: adding pattern simple descriptions
especially for testing
* chore: removed the comment
as it got moved to the description previously

* Revert "chore: formatting"

This reverts commit 4ffd569.

* Revert "chore:formatting"

This reverts commit c21504b.

* build: regenerated yarn.lock

Co-authored-by: Maximilian <[email protected]>
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
@mfranzke
feat: define initial viewport (pattern-lab#1386)
fb76bc9
antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
@mfranzke
refactor: updated lerna dependency (pattern-lab#1382)
83082b7 
* chore(docs): some typos

missed to replace mustache initially and incorrect handlebars two times (both in package name and URL)

* Revert "Merge pull request pattern-lab#2 from pattern-lab/dev"

This reverts commit 7812878, reversing
changes made to 26db979.

* Revert "Merge pull request pattern-lab#1 from pattern-lab/dev"

This reverts commit 26db979, reversing
changes made to fc90750.

* Revert "chore(docs): some typos"

This reverts commit 271dc8d.

* refactor: updated lerna dependency

executed a simple migration script as stated in https://github.com/lerna/lerna/blob/main/CHANGELOG.md#400-2021-02-10

* chore: formatting

* chore: code optimizations

that are mentioned by the github pipeline as well

* chore: formatting

* Revert "chore: formatting"

This reverts commit 60a3d64.

* chore:formatting

* chore: formatting

* Revert "Merge branch 'dev' into refactor/updated-lerna-dependency"

This reverts commit ab5e103, reversing
changes made to e7123c1.

* Revert "chore: formatting"

This reverts commit e7123c1.

* chore: formatting

* Revert "Revert "Merge branch 'dev' into refactor/updated-lerna-dependency""

This reverts commit ed365ea.

* Revert "Revert "Revert "Merge branch 'dev' into refactor/updated-lerna-dependency"""

This reverts commit 2c27360.

* refactor: moved dependencies to devDependencies @ cli (pattern-lab#1384)

* refactor: moved dependencies to devDependencies

* build: regenerated package-lock.json

* chore: reformatting

* chore: code optimizations

that are mentioned by the github pipeline as well

* Revert "chore: reformatting"

This reverts commit a5cfdd5.

* build: regenerated package-lock.json

* refactor: updated 11ty dependencies (pattern-lab#1383)

* refactor: updated 11ty dependencies

* Revert "refactor: updated 11ty dependencies"

This reverts commit f9743ed.

* build: updated @11ty/eleventy-plugin-rss dependency

* chore: formatting

* chore: code optimizations

that are mentioned by the github pipeline as well

* Revert "chore: formatting"

This reverts commit 8abf6fc.

* build: updated @11ty/eleventy-navigation dependency

* chore: formatting

* build: updated @11ty/eleventy-plugin-syntaxhighlight dependency

* Revert "chore: formatting"

This reverts commit cd323e7.

* build: updated @11ty/eleventy dependency

* chore: formattingbuild: updated @11ty/eleventy dependency

* build: regenerated package-lock.json

* build: regenerated yarn.lock

* feat: define initial viewport (pattern-lab#1386)

* refactor: updated http-auth dependency (pattern-lab#1379)

* refactor: updated http-auth dependency
http-auth: added necessary new dependency http-auth-connect that provides the method .connect that got extracted from the original one.
* chore: formatting
* chore: code optimizations
that are mentioned by the github pipeline as well
* Revert "chore: formatting"
This reverts commit 5b7a95b.

* chore: adding simple pattern descriptions (pattern-lab#1378)

* chore: adding pattern simple descriptions
especially for testing
* chore: removed the comment
as it got moved to the description previously

* Revert "chore: formatting"

This reverts commit 4ffd569.

* Revert "chore:formatting"

This reverts commit c21504b.

* build: regenerated yarn.lock

Co-authored-by: Maximilian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosefBredereck JosefBredereck JosefBredereck approved these changes

@sghoweri sghoweri Awaiting requested review from sghoweri sghoweri is a code owner

Assignees
No one assigned
Labels
enhancement ✨ released 🚀 request 🙏 uikit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No possibility to deactivate the viewport opening at the persisted size
2 participants
@mfranzke @JosefBredereck