Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS actions to compileAsHtml templates #649

Closed
AllenBW opened this issue Oct 16, 2017 · 6 comments
Closed

JS actions to compileAsHtml templates #649

AllenBW opened this issue Oct 16, 2017 · 6 comments

Comments

@AllenBW
Copy link
Contributor

AllenBW commented Oct 16, 2017

so the ask is this, you want to add an ng-click, or a popover or ANYthing to an info status card row item
the problem is this, not doable because of the way trustashtml was not meant to build directives

so the solution is this, (well inspired by this) a directive that watches the template and recompiles it when necessary https://docs.angularjs.org/api/ng/service/$compile#example

@AllenBW
Copy link
Contributor Author

AllenBW commented Oct 16, 2017

@jeff-phillips-18 can ya fill me up with labels and assign to meeeee ? ❤️ 🙇‍♀️

@dtaylor113
Copy link
Member

Hmm...only issue is that we are trying to stay away from $compile because it is not supported in angular 2+

@AllenBW
Copy link
Contributor Author

AllenBW commented Oct 16, 2017

SNAP, good headsup @dtaylor113 didn't know, i saw it used in heatmap and thought it was ok....

@AllenBW
Copy link
Contributor Author

AllenBW commented Oct 16, 2017

@dtaylor113 ya think that makes this ask doa?

@dtaylor113
Copy link
Member

yeah, heatmap is the only remaining component with $compile, just because we haven't had time to investigate how to get it working without a $compile.

@AllenBW
Copy link
Contributor Author

AllenBW commented Oct 17, 2017

Ok gonna close this, will hand role the thing in the app. Thanks for the eyes @dtaylor113 🙇‍♀️

@AllenBW AllenBW closed this as completed Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants