Resource Details Page - ie: bulk cards, everything is a card #910
Conversation
AllenBW
changed the title
AllenBW
force-pushed
the
PT/#147640893-resource-details-component
branch
3 times, most recently
from
a4111f4
to
30272f3
Compare
AllenBW
force-pushed
the
PT/#147640893-resource-details-component
branch
7 times, most recently
from
342c16f
to
54d009d
Compare
|
Update for today, finished off smart state analysis, did some more work on disk usage, began work on timeline, ran into trouble restoring a db with metric rollup info, will continue to troubleshoot that in the coming days... Its the reason we have no new ss, no db 😆 |
AllenBW
force-pushed
the
PT/#147640893-resource-details-component
branch
3 times, most recently
from
6d23c77
to
a00330d
Compare
AllenBW
force-pushed
the
PT/#147640893-resource-details-component
branch
from
a00330d
to
65129be
Compare
|
@serenamarie125 wanted to touch base on the info status card mentioned in our last SUI/UXD Sync, (used in the first two columns of the first row in the mock for this work) |
|
Hey @AllenBW this card type has not yet been developed in PatternFly ... I think that contributing it back to PatternFly first would make a lot of sense, but unsure of your timeline? |
|
During that meeting you had mentioned that there might be resources working on it? Was checking as I didn't want to duplicate efforts. |
|
@AllenBW we weren't able to get anyone on it |
|
@serenamarie125 new question! ok disk usage tootip, my understanding is ya wanta display usage, title, and dev type? |
AllenBW
force-pushed
the
PT/#147640893-resource-details-component
branch
2 times, most recently
from
2478c8b
to
34761d4
Compare
|
@AllenBW is this ready for @serenamarie125 to give final review? /cc @Loicavenel |
|
@chriskacerguis aside from coverage, yep! we're all good here |
|
i don't want to cry 🐺 butttttt coveralls is reporting the coverage of this file fell, but in fact we have complete coverage 😭 |
|
@AllenBW ok. Odd. |
|
LGTM - Waiting for PM and UXD signoff. |
|
looks good for me |
AllenBW
force-pushed
the
PT/#147640893-resource-details-component
branch
2 times, most recently
from
dd14067
to
433b512
Compare
AllenBW
force-pushed
the
PT/#147640893-resource-details-component
branch
from
433b512
to
10f637b
Compare
|
@AllenBW if there is a single hostname, you should only display that hostname, with no extra text. It seems like you are still showing the "1 Hostname " + Field Level Help icon
|
|
Oops @AllenBW after reading the text more carefully, I guess you are handling that 💃 Otherwise looks 👌💯 |
|
@miq-bot remove_labels ux/review |
|
@miq_bot add_labels ux/approved |
|
Per #910 (comment) should have added ux/approved label, but didn't. Manaully adding. |
|
Checked commits AllenBW/manageiq-ui-service@2a8884e~...5eb26ed with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@serenamarie125 updated as per your request! also, jah, the 1 host name was for demonstration purposes, check out the ss below, found one with two (and one with one) |
|
Going to merge, since we have 100% coverage on what was done. |
https://docs.google.com/document/d/1kvWtq4xFX4Upqm5dfws8g6Z4OxBOzwjBH3hmIv608cc
https://bugzilla.redhat.com/show_bug.cgi?id=1497733
closes #931
TODO
Now with timeline power data (from the last 7 days)
i found something with custom attributes!
Keep in mind, db I have doesn't have hourly stats for metric rollups... (as in nowish)
UXD Mock
Work done in support of this pr (moved from the needs list below)
info status card, similar to http://www.patternfly.org/pattern-library/cards/aggregate-status-card/oh look here it is! feat(pfInfoStatusCard): Adds Info Status Card and tests patternfly/angular-patternfly#630 and chore(pfInfoStatusCard): Tweak infoStatusCard as per UX guidance patternfly/angular-patternfly#632ip_addressandhostnamesJS actions to compileAsHtml templates patternfly/angular-patternfly#649 (for popover in info-status-cards)