Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define header styling for React examples on website #1139

Closed
Tracked by #2796
mcarrano opened this issue Mar 15, 2022 · 2 comments
Closed
Tracked by #2796

Define header styling for React examples on website #1139

mcarrano opened this issue Mar 15, 2022 · 2 comments
Milestone

Comments

@mcarrano
Copy link
Member

Many of our React examples are written to include optional settings that allow a single example to show the affect of changing component properties. These are currently just exposed as part of the example itself which can sometimes make it difficult to differentiate the actual example from the controls associated with it. The need is to create a visual template for these examples that can apply standard styles to a header area that will contain all such controls. Here are links to some examples that have optional controls:

https://www.patternfly.org/v4/components/tooltip/#options
https://www.patternfly.org/v4/components/card#with-modifiers
https://www.patternfly.org/v4/components/popover#advanced
https://www.patternfly.org/v4/components/table#composable-basic

In addition to providing styling, we should also have some guidelines for developers creating examples about what controls to use and when.

@mcarrano mcarrano added this to the 2022.06 milestone Mar 18, 2022
@mcarrano
Copy link
Member Author

mcarrano commented Apr 7, 2022

Close in favor of this larger issue. #1146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants