-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): added mobile jumplinks and example styling #2867
chore(docs): added mobile jumplinks and example styling #2867
Conversation
PF4 preview: https://patternfly-org-pr-2867-v4.surge.sh/v4 |
@mcarrano @maryshak1996 a couple notes/questions on this PR:
|
@mcarrano @maryshak1996 I've updated this PR per our discussion:
|
@evwilkin thanks for making these updates. Overall I think this looks a whole lot better! I just have one question/nit. By making the tool buttons below the example plain buttons, they no longer display a selected state. You'll notice that in the existing site, when the code window is open the "<>JS" or "<>TS" button is shown as selected/active. I'm not sure that's a big deal, but I wanted to raise it as an issue. What do you think @maryshak1996 ? In looking at this, I was also wondering how those are implemented now. Even though they function as buttons, they have dropdown styling that leads to them having a blue underline when open. Were these some type of custom button? Would we want to customize the plain button to give it a selected state? |
@mcarrano thanks for taking a look. The controls beneath each example & the expandable code below them are the The |
@evwilkin thanks for the added info. Yes I do recall that we styled the code editor buttons that way. @maryshak1996 I'll defer to you, should we do any more customization of these buttons or do you think they are good as is? |
…ls, updated example background colors to variables
@mcarrano @maryshak1996 per our conversation I've made 2 additional changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @evwilkin . Thanks for making these updates!
Closes #2843
This PR:
.pf-c-code-editor__header
above example code except when example code is expanded