fix(demos): fix typography on demo pages #1083
Conversation
| @@ -192,6 +192,7 @@ class PageLayoutDefaultNav extends React.Component { | |||
| isManagedSidebar | |||
| skipToContent={PageSkipToContent} | |||
| breadcrumb={PageBreadcrumb} | |||
| className="pf4-site-demo-typography" | |||
There was a problem hiding this comment.
Anything under _repos will get overwritten when newer patternfly-react and core versions are pulled in. So this would only be a temporary solution. Perhaps we can add a class identifier upstream?
There was a problem hiding this comment.
@jschuler this is really only necessary until PatternFly moves over to using the Red Hat typography (which will then match the rest of PatternFly.org). I don't know the timeline for that (I couldn't find an issue in the patternfly/patternfly-next repo), but it probably wouldn't make sense to put an identifier upstream.
There was a problem hiding this comment.
@mindreeper2420 there is a PR up in pf next currently that adds an option to use the new font family: patternfly/patternfly#1813 .. I dont know how long until it will be merged but I can check with @mcoker
|
@mindreeper2420 theres a decent amount of issues with these demos where they're pulling in website styling, i.e. the blue border on the nav, and the padding around the main section areas.
|
|
@christiemolloy I started to notice those other issues as well. I'm thinking that it'd be better to both wait for the PatternFly PR to be merged, and then update various items with PatternFly site classes (either a whole-site wrapper class, or individual ones on elements). Either that, or we could write site-specific components. |
|
Closing, as the work for updating PatternFly to use Red Hat fonts has begun, nullifying the need for this. |
Applies the Overpass font family from PatternFly to the demo pages.
This will be able to be removed once PatternFly utilizes Red Hat typography.
fixes issue #1080