Update to Alpha versions #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Surge links for review: |
mcoker
reviewed
May 31, 2024
mcoker
reviewed
May 31, 2024
There was a problem hiding this comment.
@jessiehuff took a look and left some comments, only got through about half of the changes, but hopefully this is helpful! I was also just reading the CSS/changes and didn't track everything down in the examples/demo to see the role of classes/vars, so apologies if some of these are off base. I'm happy to review with you some more though if you'd like, just lemme know!
packages/module/src/ConsoleInternal/components/catalog/_catalog.scss
Outdated
Show resolved
Hide resolved
packages/module/src/ConsoleInternal/components/catalog/_catalog.scss
Outdated
Show resolved
Hide resolved
packages/module/src/ConsoleInternal/components/catalog/_catalog.scss
Outdated
Show resolved
Hide resolved
packages/module/src/ConsoleInternal/components/catalog/_catalog.scss
Outdated
Show resolved
Hide resolved
packages/module/src/ConsoleShared/src/components/layout/PageLayout.scss
Outdated
Show resolved
Hide resolved
packages/module/src/ConsoleShared/src/components/spotlight/spotlight.scss
Outdated
Show resolved
Hide resolved
packages/module/src/ConsoleShared/src/components/spotlight/spotlight.scss
Outdated
Show resolved
Hide resolved
packages/module/src/ConsoleShared/src/components/spotlight/spotlight.scss
Outdated
Show resolved
Hide resolved
36 tasks
kmcfaul
approved these changes
Jun 11, 2024
|
There are styling issues that should be addressed as a followup to this PR: #299 |
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #259