Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): update examples and html structure. #2390

Closed
christiemolloy opened this issue Jun 28, 2019 · 2 comments · Fixed by #2422
Closed

feat(accordion): update examples and html structure. #2390

christiemolloy opened this issue Jun 28, 2019 · 2 comments · Fixed by #2422
Assignees
Labels
Milestone

Comments

@christiemolloy
Copy link
Member

Related to this issue in Core: patternfly/patternfly#1913

In Core we added a new example and updated an old example of the Accordion, so that now there is one example that uses just <div> and <h1 - h6> in its html markup, and another that uses "definition list" <dl>, <dt> and <dd> in its html markup.

In Core we don't have defaults the same way that React does, but its important to keep the example order the same from Core to React. @jgiardino suggested that the default in React may be the definition list, and then if a user specifies a heading level it will use divs and h1-h6. patternfly/patternfly#1990 (comment)

@rachael-phillips
Copy link
Contributor

@boaz0 will #2422 solve this issue?

@boaz0
Copy link
Member

boaz0 commented Jul 23, 2019

@rachael-phillips yes it will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants